ignore_result()

tools/flags/SkCommandLineFlags.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCommandLineFlags.h"
 #include "SkTDArray.h"
 #include "SkTSort.h"
 
 DEFINE_bool(undefok, false, "Silently ignore unknown flags instead of crashing.");
 
+template <typename T> static void ignore_result(const T&) {}

[tfarina, 2015/05/04 17:39:31]

I checked in chromium, and this is equal how they do in base/macros.h.

+
 bool SkFlagInfo::CreateStringFlag(const char* name, const char* shortName,
                                   SkCommandLineFlags::StringArray* pStrings,
                                   const char* defaultValue, const char* helpString) {
     SkFlagInfo* info = SkNEW_ARGS(SkFlagInfo, (name, shortName, kString_FlagType, helpString));
     info->fDefaultString.set(defaultValue);
 
     info->fStrings = pStrings;
     SetDefaultStrings(pStrings, defaultValue);
     return true;
 }
@@ skipping 253 matching lines @@
                                 if (parse_bool_arg(argv[i], &value)) {
                                     flag->setBool(value);
                                 }
                             }
                             break;
                         case SkFlagInfo::kString_FlagType:
                             flag->resetStrings();
                             // Add all arguments until another flag is reached.
                             while (i+1 < argc) {
                                 char* end = NULL;
-                                (void)strtod(argv[i+1], &end); // Negative numbers aren't flags.
+                                // Negative numbers aren't flags.
+                                ignore_result(strtod(argv[i+1], &end));
                                 if (end == argv[i+1] && SkStrStartsWith(argv[i+1], '-')) {
                                     break;
                                 }
                                 i++;
                                 flag->append(argv[i]);
                             }
                             break;
                         case SkFlagInfo::kInt_FlagType:
                             i++;
                             flag->setInt(atoi(argv[i]));
@@ skipping 73 matching lines @@
 }
 
 }  // namespace
 
 bool SkCommandLineFlags::ShouldSkip(const SkTDArray<const char*>& strings, const char* name) {
     return ShouldSkipImpl(strings, name);
 }
 bool SkCommandLineFlags::ShouldSkip(const StringArray& strings, const char* name) {
     return ShouldSkipImpl(strings, name);
 }