Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1127573004: MIPS: Collect type feedback on result of Math.[round|ceil|floor] (Closed)

Created:
5 years, 7 months ago by balazs.kilvady
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Collect type feedback on result of Math.[round|ceil|floor] Original commit message: By recording invocations of these builtins that can return -0, we now learn to not emit Crankshaft code that only handles integer results, avoiding deopt loops. BUG=

Patch Set 1 #

Patch Set 2 : 64 bits port. #

Total comments: 1

Patch Set 3 : Use SmiScale. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -0 lines) Patch
M src/mips/code-stubs-mips.cc View 3 chunks +175 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 chunks +175 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
paul.l...
mips32 part l-g-t-m
5 years, 7 months ago (2015-05-04 16:12:25 UTC) #2
paul.l...
One small optimization issue, then mips64 l-g-t-m also. https://codereview.chromium.org/1127573004/diff/20001/src/mips64/code-stubs-mips64.cc File src/mips64/code-stubs-mips64.cc (right): https://codereview.chromium.org/1127573004/diff/20001/src/mips64/code-stubs-mips64.cc#newcode2966 src/mips64/code-stubs-mips64.cc:2966: __ ...
5 years, 7 months ago (2015-05-04 18:22:39 UTC) #4
paul.l...
Done. l-g-t-m.
5 years, 7 months ago (2015-05-04 18:55:17 UTC) #5
danno
5 years, 7 months ago (2015-05-05 06:39:41 UTC) #6
Thanks a lot for the patch! I'll integrate it into my patch for the other
platforms.

Powered by Google App Engine
This is Rietveld 408576698