MIPS: Collect type feedback on result of Math.[round|ceil|floor]

src/mips64/code-stubs-mips64.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #if V8_TARGET_ARCH_MIPS64
 
 #include "src/bootstrapper.h"
 #include "src/code-stubs.h"
@@ skipping 2912 matching lines @@
   CallFunctionNoFeedback(masm,
                          arg_count(),
                          true,
                          CallAsMethod());
 
   // Unreachable.
   __ stop("Unexpected code address");
 }
 
 
+void CallIC_RoundStub::Generate(MacroAssembler* masm) {
+  Register function = a1;
+  Register vector = a2;
+  Register slot = a3;
+
+  Register temp1 = a0;
+  Register temp2 = a4;
+  DoubleRegister double_temp1 = f12;
+  DoubleRegister double_temp2 = f14;
+  Label tail, miss;
+
+  // Ensure nobody has snuck in another function.
+  __ BranchIfNotBuiltin(function, temp1, kMathRound, &miss);
+
+  if (arg_count() > 0) {
+    __ ld(temp1, MemOperand(sp, (arg_count() - 1) * kPointerSize));
+    Handle<Map> map = isolate()->factory()->heap_number_map();
+    __ CheckMap(temp1, temp2, map, &tail, DO_SMI_CHECK);
+    __ ldc1(double_temp1, FieldMemOperand(temp1, HeapNumber::kValueOffset));
+
+    // If the number is >0, it doesn't round to -0
+    __ Move(double_temp2, 0.0);
+    __ BranchF64(&tail, nullptr, gt, double_temp1, double_temp2);
+
+    // If the number is <-.5, it doesn't round to -0
+    __ Move(double_temp2, -.5);
+    __ BranchF64(&tail, nullptr, lt, double_temp1, double_temp2);
+
+    // +0 doesn't round to -0
+    __ FmoveHigh(temp1, double_temp1);
+    __ Branch(&tail, ne, temp1, Operand(0xffffffff80000000));
+
+    __ SmiUntag(temp1, slot);
+    __ dsll(temp1, temp1, kPointerSizeLog2);

[paul.l..., 2015/05/04 18:22:39]

Use SmiScale(temp1, slot, kPointerSizeLog2) here to save one instruction?
Also in next 2 functions...

+    __ Daddu(temp1, temp1, vector);
+    __ li(temp2, Operand(Smi::FromInt(kHasReturnedMinusZeroSentinel)));
+    __ sd(temp2,
+          FieldMemOperand(temp1, FixedArray::kHeaderSize + kPointerSize));
+  }
+
+  __ bind(&tail);
+  // The slow case, we need this no matter what to complete a call after a miss.
+  CallFunctionNoFeedback(masm, arg_count(), true, CallAsMethod());
+
+  // Unreachable.
+  __ stop("Unreachable");
+
+  __ bind(&miss);
+  GenerateMiss(masm);
+  __ Branch(&tail);
+}
+
+
+void CallIC_FloorStub::Generate(MacroAssembler* masm) {
+  Register function = a1;
+  Register vector = a2;
+  Register slot = a3;
+
+  Register temp1 = a0;
+  Register temp2 = a4;
+  DoubleRegister double_temp = f12;
+  Label tail, miss;
+
+  // Ensure nobody has snuck in another function.
+  __ BranchIfNotBuiltin(function, temp1, kMathFloor, &miss);
+
+  if (arg_count() > 0) {
+    __ ld(temp1, MemOperand(sp, (arg_count() - 1) * kPointerSize));
+    Handle<Map> map = isolate()->factory()->heap_number_map();
+    __ CheckMap(temp1, temp2, map, &tail, DO_SMI_CHECK);
+    __ ldc1(double_temp, FieldMemOperand(temp1, HeapNumber::kValueOffset));
+
+    // Only -0 floors to -0.
+    __ FmoveHigh(temp1, double_temp);
+    __ Branch(&tail, ne, temp1, Operand(0xffffffff80000000));
+    __ FmoveLow(temp1, double_temp);
+    __ Branch(&tail, ne, temp1, Operand(zero_reg));
+
+    __ SmiUntag(temp1, slot);
+    __ dsll(temp1, temp1, kPointerSizeLog2);
+    __ Daddu(temp1, temp1, vector);
+    __ li(temp2, Operand(Smi::FromInt(kHasReturnedMinusZeroSentinel)));
+    __ sd(temp2,
+          FieldMemOperand(temp1, FixedArray::kHeaderSize + kPointerSize));
+  }
+
+  __ bind(&tail);
+  // The slow case, we need this no matter what to complete a call after a miss.
+  CallFunctionNoFeedback(masm, arg_count(), true, CallAsMethod());
+
+  // Unreachable.
+  __ stop("Unreachable");
+
+  __ bind(&miss);
+  GenerateMiss(masm);
+  __ Branch(&tail);
+}
+
+
+void CallIC_CeilStub::Generate(MacroAssembler* masm) {
+  Register function = a1;
+  Register vector = a2;
+  Register slot = a3;
+
+  Register temp1 = a0;
+  Register temp2 = a4;
+  DoubleRegister double_temp1 = f12;
+  DoubleRegister double_temp2 = f14;
+  Label tail, miss;
+
+  // Ensure nobody has snuck in another function.
+  __ BranchIfNotBuiltin(function, temp1, kMathCeil, &miss);
+
+  if (arg_count() > 0) {
+    __ ld(temp1, MemOperand(sp, (arg_count() - 1) * kPointerSize));
+    Handle<Map> map = isolate()->factory()->heap_number_map();
+    __ CheckMap(temp1, temp2, map, &tail, DO_SMI_CHECK);
+    __ ldc1(double_temp1, FieldMemOperand(temp1, HeapNumber::kValueOffset));
+
+    // If the number is >0, it doesn't round to -0
+    __ Move(double_temp2, 0.0);
+    __ BranchF64(&tail, nullptr, gt, double_temp1, double_temp2);
+
+    // If the number is <=-1, it doesn't round to -0
+    __ Move(double_temp2, -1.0);
+    __ BranchF64(&tail, nullptr, le, double_temp1, double_temp2);
+
+    // +0 doesn't round to -0.
+    __ FmoveHigh(temp1, double_temp1);
+    __ Branch(&tail, ne, temp1, Operand(0xffffffff80000000));
+
+    __ SmiUntag(temp1, slot);
+    __ dsll(temp1, temp1, kPointerSizeLog2);
+    __ Daddu(temp1, temp1, vector);
+    __ li(temp2, Operand(Smi::FromInt(kHasReturnedMinusZeroSentinel)));
+    __ sd(temp2,
+          FieldMemOperand(temp1, FixedArray::kHeaderSize + kPointerSize));
+  }
+
+  __ bind(&tail);
+  // The slow case, we need this no matter what to complete a call after a miss.
+  CallFunctionNoFeedback(masm, arg_count(), true, CallAsMethod());
+
+  // Unreachable.
+  __ stop("Unreachable");
+
+  __ bind(&miss);
+  GenerateMiss(masm);
+  __ Branch(&tail);
+}
+
+
 void CallICStub::Generate(MacroAssembler* masm) {
   // a1 - function
   // a3 - slot id (Smi)
   // a2 - vector
   const int with_types_offset =
       FixedArray::OffsetOfElementAt(TypeFeedbackVector::kWithTypesIndex);
   const int generic_offset =
       FixedArray::OffsetOfElementAt(TypeFeedbackVector::kGenericCountIndex);
   Label extra_checks_or_miss, slow_start;
   Label slow, non_function, wrap, cont;
@@ skipping 90 matching lines @@
 
   // Goto miss case if we do not have a function.
   __ GetObjectType(a1, a4, a4);
   __ Branch(&miss, ne, a4, Operand(JS_FUNCTION_TYPE));
 
   // Make sure the function is not the Array() function, which requires special
   // behavior on MISS.
   __ LoadGlobalFunction(Context::ARRAY_FUNCTION_INDEX, a4);
   __ Branch(&miss, eq, a1, Operand(a4));
 
+  // Some builtin functions require special handling, miss to the runtime.
+  __ ld(t0, FieldMemOperand(a1, JSFunction::kSharedFunctionInfoOffset));
+  __ ld(t0, FieldMemOperand(t0, SharedFunctionInfo::kFunctionDataOffset));
+  __ Branch(&miss, ne, t0, Operand(Smi::FromInt(0)));
+
   // Update stats.
   __ ld(a4, FieldMemOperand(a2, with_types_offset));
   __ Daddu(a4, a4, Operand(Smi::FromInt(1)));
   __ sd(a4, FieldMemOperand(a2, with_types_offset));
 
   // Store the function. Use a stub since we need a frame for allocation.
   // a2 - vector
   // a3 - slot
   // a1 - function
   {
@@ skipping 1574 matching lines @@
 }
 
 
 void CallIC_ArrayTrampolineStub::Generate(MacroAssembler* masm) {
   EmitLoadTypeFeedbackVector(masm, a2);
   CallIC_ArrayStub stub(isolate(), state());
   __ Jump(stub.GetCode(), RelocInfo::CODE_TARGET);
 }
 
 
+void CallIC_RoundTrampolineStub::Generate(MacroAssembler* masm) {
+  EmitLoadTypeFeedbackVector(masm, a2);
+  CallIC_RoundStub stub(isolate(), state());
+  __ Jump(stub.GetCode(), RelocInfo::CODE_TARGET);
+}
+
+
+void CallIC_FloorTrampolineStub::Generate(MacroAssembler* masm) {
+  EmitLoadTypeFeedbackVector(masm, a2);
+  CallIC_FloorStub stub(isolate(), state());
+  __ Jump(stub.GetCode(), RelocInfo::CODE_TARGET);
+}
+
+
+void CallIC_CeilTrampolineStub::Generate(MacroAssembler* masm) {
+  EmitLoadTypeFeedbackVector(masm, a2);
+  CallIC_CeilStub stub(isolate(), state());
+  __ Jump(stub.GetCode(), RelocInfo::CODE_TARGET);
+}
+
+
 void VectorRawLoadStub::Generate(MacroAssembler* masm) {
   GenerateImpl(masm, false);
 }
 
 
 void VectorRawLoadStub::GenerateForTrampoline(MacroAssembler* masm) {
   GenerateImpl(masm, true);
 }
 
 
@@ skipping 890 matching lines @@
                            kStackUnwindSpace, kInvalidStackOffset,
                            MemOperand(fp, 6 * kPointerSize), NULL);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_MIPS64