Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 11275303: chromeos: Stop creating symlinks in DriveCacheTest (Closed)

Created:
8 years, 1 month ago by hashimoto
Modified:
8 years, 1 month ago
Reviewers:
kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Stop creating symlinks in DriveCacheTest DriveCache will stop creating symlinks, tests should not rely on symlinks. TestInitializeCache is removed because this test does not add any test coverage. BUG=159760 TEST=unit_tests --gtest_filter="DriveCacheTest.*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167625

Patch Set 1 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -139 lines) Patch
M chrome/browser/chromeos/drive/drive_cache_unittest.cc View 6 chunks +99 lines, -139 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
8 years, 1 month ago (2012-11-14 05:49:23 UTC) #1
kinaba
lgtm
8 years, 1 month ago (2012-11-14 06:09:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11275303/5001
8 years, 1 month ago (2012-11-14 06:10:30 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 08:31:05 UTC) #4
Change committed as 167625

Powered by Google App Engine
This is Rietveld 408576698