Chromium Code Reviews
Help | Chromium Project | Sign in
(684)

Issue 11275225: Add a callback to RemoteFileSyncService for reporting errors. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by tzik
Modified:
1 year, 5 months ago
Reviewers:
kinuko
CC:
chromium-reviews_chromium.org, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Add a callback to RemoteFileSyncService for reporting errors for better error handling.

BUG=156041
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166898

Patch Set 1 #

Patch Set 2 : build fix #

Total comments: 2

Patch Set 3 : +TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Lint Patch
M chrome/browser/sync_file_system/mock_remote_file_sync_service.h View 1 1 chunk +6 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/sync_file_system/remote_file_sync_service.h View 2 chunks +13 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 6
tzik
PTAL
1 year, 5 months ago #1
kinuko
lgtm except that: Please run try jobs and fill appropriate bug number (156041?).
1 year, 5 months ago #2
kinuko
http://codereview.chromium.org/11275225/diff/1001/chrome/browser/sync_file_system/sync_file_system_service.cc File chrome/browser/sync_file_system/sync_file_system_service.cc (right): http://codereview.chromium.org/11275225/diff/1001/chrome/browser/sync_file_system/sync_file_system_service.cc#newcode61 chrome/browser/sync_file_system/sync_file_system_service.cc:61: app_origin, fileapi::SyncStatusCallback()); Please add TODO to handle this callback ...
1 year, 5 months ago #3
tzik
Thanks! http://codereview.chromium.org/11275225/diff/1001/chrome/browser/sync_file_system/sync_file_system_service.cc File chrome/browser/sync_file_system/sync_file_system_service.cc (right): http://codereview.chromium.org/11275225/diff/1001/chrome/browser/sync_file_system/sync_file_system_service.cc#newcode61 chrome/browser/sync_file_system/sync_file_system_service.cc:61: app_origin, fileapi::SyncStatusCallback()); On 2012/11/09 07:44:45, kinuko wrote: > ...
1 year, 5 months ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/11275225/6002
1 year, 5 months ago #5
I haz the power (commit-bot)
1 year, 5 months ago #6
Change committed as 166898
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6