chrome/browser/extensions/web_view_browsertest.cc - Issue 11275209: Revert r165772: Keep browser process alive while there are platform apps with background pages runn…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/web_view_browsertest.cc

Issue 11275209: Revert r165772: Keep browser process alive while there are platform apps with background pages runn… (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/platform_app_browsertest.cc ('K') | « chrome/browser/extensions/platform_app_service_factory.cc ('k') | chrome/browser/profiles/profile_dependency_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/web_view_browsertest.cc

===================================================================

--- chrome/browser/extensions/web_view_browsertest.cc (revision 166679)

+++ chrome/browser/extensions/web_view_browsertest.cc (working copy)

@@ -205,8 +205,6 @@

named_partition_contents1,

&cookie_size, &cookie_value);

EXPECT_EQ("", cookie_value);

- CloseShellWindowsAndWaitForAppToExit();

davidjames 2012/11/08 17:38:48 The original CL had trivial conflicts on this line

}

// This tests DOM storage isolation for packaged apps with webview tags. It

@@ -295,8 +293,6 @@

default_tag_contents1->GetRenderViewHost(), std::wstring(),

get_session_storage.c_str(), &output));

EXPECT_STREQ("badval", output.c_str());

- CloseShellWindowsAndWaitForAppToExit();

davidjames 2012/11/08 17:38:48 The CL I reverted added the CloseShellWindowsAndWa

}

// This tests IndexedDB isolation for packaged apps with webview tags. It loads

@@ -383,6 +379,4 @@

ExecuteScriptWaitForTitle(chrome::GetWebContentsAt(browser(), 0),

script, "db not found");

ExecuteScriptWaitForTitle(default_tag_contents1, script, "db not found");

- CloseShellWindowsAndWaitForAppToExit();

davidjames 2012/11/08 17:38:48 The CL I reverted added the CloseShellWindowsAndWa

}