Revert r165772: Keep browser process alive while there are platform apps with background pages runn…

chrome/browser/extensions/web_view_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/automation/automation_util.h"
 #include "chrome/browser/extensions/platform_app_browsertest_util.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "chrome/test/base/test_launcher_utils.h"
@@ skipping 187 matching lines @@
   automation_util::GetCookies(GURL("http://localhost"),
                               cookie_contents2,
                               &cookie_size, &cookie_value);
   EXPECT_EQ("guest1=true; guest2=true", cookie_value);
 
   // The third tag should not have any cookies as it is in a separate partition.
   automation_util::GetCookies(GURL("http://localhost"),
                               named_partition_contents1,
                               &cookie_size, &cookie_value);
   EXPECT_EQ("", cookie_value);
-
-  CloseShellWindowsAndWaitForAppToExit();

[davidjames, 2012/11/08 17:38:48]

The original CL had trivial conflicts on this line, which I resolved easily.

 }
 
 // This tests DOM storage isolation for packaged apps with webview tags. It
 // loads an app with multiple webview tags and each tag sets DOM storage
 // entries, which the test checks to ensure proper storage isolation is
 // enforced.
 IN_PROC_BROWSER_TEST_F(WebViewTest, DOMStorageIsolation) {
   ASSERT_TRUE(StartTestServer());
   GURL regular_url = test_server()->GetURL("files/title1.html");
 
@@ skipping 68 matching lines @@
       std::wstring(), get_session_storage.c_str(), &output));
   EXPECT_STREQ("badval", output.c_str());
   EXPECT_TRUE(ExecuteJavaScriptAndExtractString(
       default_tag_contents1->GetRenderViewHost(), std::wstring(),
       get_local_storage.c_str(), &output));
   EXPECT_STREQ("badval", output.c_str());
   EXPECT_TRUE(ExecuteJavaScriptAndExtractString(
       default_tag_contents1->GetRenderViewHost(), std::wstring(),
       get_session_storage.c_str(), &output));
   EXPECT_STREQ("badval", output.c_str());
-
-  CloseShellWindowsAndWaitForAppToExit();

[davidjames, 2012/11/08 17:38:48]

The CL I reverted added the CloseShellWindowsAndWaitForAppToExit API and added
CloseShellWindowsAndWaitForAppToExit() calls at the bottom of a bunch of tests.
This call was added in a subsequent CL, but still needs to be removed, so I
removed it.

 }
 
 // This tests IndexedDB isolation for packaged apps with webview tags. It loads
 // an app with multiple webview tags and each tag creates an IndexedDB record,
 // which the test checks to ensure proper storage isolation is enforced.
 IN_PROC_BROWSER_TEST_F(WebViewTest, IndexedDBIsolation) {
   ASSERT_TRUE(StartTestServer());
   GURL regular_url = test_server()->GetURL("files/title1.html");
 
   content::WebContents* default_tag_contents1;
@@ skipping 66 matching lines @@
   const char* script =
     "indexedDB.open('isolation').onsuccess = function(e) {"
     "  if (e.target.result.version == 1)"
     "    document.title = 'db not found';"
     "  else "
     "    document.title = 'error';"
     "}";
   ExecuteScriptWaitForTitle(chrome::GetWebContentsAt(browser(), 0),
                             script, "db not found");
   ExecuteScriptWaitForTitle(default_tag_contents1, script, "db not found");
-
-  CloseShellWindowsAndWaitForAppToExit();

[davidjames, 2012/11/08 17:38:48]

The CL I reverted added the CloseShellWindowsAndWaitForAppToExit API and added
CloseShellWindowsAndWaitForAppToExit() calls at the bottom of a bunch of tests.
This call was added in a subsequent CL, but still needs to be removed, so I
removed it.

 }