Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 11275156: Merge 133252 - HTMLMediaPlayer should free m_player when src is set/changed (Closed)

Created:
8 years, 1 month ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 133252 - HTMLMediaPlayer should free m_player when src is set/changed https://bugs.webkit.org/show_bug.cgi?id=99647 Reviewed by Eric Carlson. .: * ManualTests/media-players-are-dropped-on-error.html: Added. Various scenarios are tested to make sure players aren't leaked in different ways for each of them. Source/WebCore: New ManualTest added; manual since leaking media players doesn't have layoutTestController-visible effects. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseAttribute): clearMediaPlayer() when src is set/changed (WebCore::HTMLMediaElement::userCancelledLoad): use new clearMediaPlayer() helper (WebCore::HTMLMediaElement::clearMediaPlayer): clear m_player and associated timers/flags (WebCore): (WebCore::HTMLMediaElement::createMediaPlayer): whitespace-only change * html/HTMLMediaElement.h: new method: createMediaPlayer(). (HTMLMediaElement): TBR=fischman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -9 lines) Patch
M ChangeLog View 1 chunk +73 lines, -0 lines 0 comments Download
A + ManualTests/media-players-are-dropped-on-error.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +19 lines, -1 line 0 comments Download
M Source/WebCore/html/HTMLMediaElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/html/HTMLMediaElement.cpp View 4 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ami GONE FROM CHROMIUM
8 years, 1 month ago (2012-11-05 20:31:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698