Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: Source/WebCore/ChangeLog

Issue 11275156: Merge 133252 - HTMLMediaPlayer should free m_player when src is set/changed (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « ManualTests/media-players-are-dropped-on-error.html ('k') | Source/WebCore/html/HTMLMediaElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 133510)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,5 +1,23 @@
-2012-10-30 Keishi Hattori <keishi@webkit.org>
+2012-11-01 Ami Fischman <fischman@chromium.org>
+ HTMLMediaPlayer should free m_player when src is set/changed
+ https://bugs.webkit.org/show_bug.cgi?id=99647
+
+ Reviewed by Eric Carlson.
+
+ New ManualTest added; manual since leaking media players doesn't have layoutTestController-visible effects.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::parseAttribute): clearMediaPlayer() when src is set/changed
+ (WebCore::HTMLMediaElement::userCancelledLoad): use new clearMediaPlayer() helper
+ (WebCore::HTMLMediaElement::clearMediaPlayer): clear m_player and associated timers/flags
+ (WebCore):
+ (WebCore::HTMLMediaElement::createMediaPlayer): whitespace-only change
+ * html/HTMLMediaElement.h: new method: createMediaPlayer().
+ (HTMLMediaElement):
+
+2012-11-01 Tom Sepez <tsepez@chromium.org>
+
F4 inside <input type=time> should not open calendar picker
https://bugs.webkit.org/show_bug.cgi?id=100730
« no previous file with comments | « ManualTests/media-players-are-dropped-on-error.html ('k') | Source/WebCore/html/HTMLMediaElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698