SkRect to gfx::Rect type conversions.

ui/views/controls/tree/tree_view_views.cc

Index: ui/views/controls/tree/tree_view_views.cc
diff --git a/ui/views/controls/tree/tree_view_views.cc b/ui/views/controls/tree/tree_view_views.cc
index 865918061a276650b8ba630df00ab7222cfa0c8b..910183606235ecdcef0962f4ef812bc6bef61fe5 100644
--- a/ui/views/controls/tree/tree_view_views.cc
+++ b/ui/views/controls/tree/tree_view_views.cc
@@ -16,6 +16,7 @@
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/image/image.h"
+#include "ui/gfx/rect_conversions.h"
 #include "ui/gfx/skia_util.h"
 #include "ui/views/background.h"
 #include "ui/views/border.h"
@@ -517,7 +518,8 @@ void TreeView::OnPaint(gfx::Canvas* canvas) {
   {
     SkRect sk_clip_rect;
     if (canvas->sk_canvas()->getClipBounds(&sk_clip_rect)) {
-      gfx::Rect clip_rect = gfx::SkRectToRect(sk_clip_rect);
+      gfx::Rect clip_rect = gfx::ToFlooredRectDeprecated(
+          gfx::SkRectToRectF(sk_clip_rect));

[sky, 2012/11/01 16:10:24]

Why does this need to use RectF and then floor it? Same comment for
table_view_views.

[danakj, 2012/11/01 17:38:27]

This is trying to paint everything touched by the clip, so ToEnclosingRect
sounds right, to paint pixels that are party inside the clip.

[danakj, 2012/11/01 17:48:28]

The clip rect given by skia is a float rect, but we're using integer rects in
ui/ which is why there is conversion happening here. It used to be implicit, so
easily forgotten. SkRect is float, SkIRect is integers.

[danakj, 2012/11/01 17:50:18]

I guess my question is why we use getClipBounds() instead of
getClipDeviceBounds(), which would then give us pixel (integer) results. I am
curious if that was intentional.

       min_y = clip_rect.y();
       max_y = clip_rect.bottom();
     } else {