Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(586)

Issue 11275067: Add gyp support for Core Data datamodel (*.xcdatamodel) files

Created:
5 years, 1 month ago by kanefsky
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai, bradn
CC:
gyp-developer_googlegroups.com, Mark Mentovai
Visibility:
Public.

Description

Add gyp support for Core Data datamodel (*.xcdatamodel) files Contributed by kanefsky@gmail.com BUG=303 TEST=Verify xcdatamodel files are editable in xcode project.

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M pylib/gyp/xcodeproj_file.py View 1 chunk +35 lines, -34 lines 0 comments Download
Trybot results:

Messages

Total messages: 3 (0 generated)
kanefsky
Hi Mark, I discovered that gyp isn't handling xcdatamodel files correctly and found a very ...
5 years, 1 month ago (2012-10-30 21:34:01 UTC) #1
Mark Mentovai
LGTM Please find a GYP committer to land this for you. I can’t as I’m ...
5 years, 1 month ago (2012-10-31 20:52:47 UTC) #2
kanefsky
5 years, 1 month ago (2012-11-01 17:29:38 UTC) #3
Hi Brad,

Mark LGTM'd this CL but he can't commit since he's in the disaster area.  Could
you do the commit?  Thanks.

Powered by Google App Engine
This is Rietveld 0eb02b776