Chromium Code Reviews
Help | Chromium Project | Sign in
(66)

Issue 11274047: Set up Proxy methods the proper way. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by rossberg
Modified:
1 year, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Set up Proxy methods the proper way.


R=mstarzinger@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=12821

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Lint Patch
M src/proxy.js View 3 chunks +6 lines, -2 lines 1 comment ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
rossberg
1 year, 6 months ago #1
Michael Starzinger
1 year, 6 months ago #2
LGTM (if comment is addressed).

https://codereview.chromium.org/11274047/diff/1/src/proxy.js
File src/proxy.js (right):

https://codereview.chromium.org/11274047/diff/1/src/proxy.js#newcode65
src/proxy.js:65: %InstallFunctions($Proxy, DONT_ENUM, [
Change this to not use a natives syntax runtime call. Also you could prepend a
call to %CheckIsBootstrapping() and put it into a separate setup method. That
would be in line with the way we set up other builtin objects.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6