Issue 11274047: Set up Proxy methods the proper way.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11274047: Set up Proxy methods the proper way. (Closed)

Created:
8 years, 1 month ago by rossberg

Modified:
8 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Set up Proxy methods the proper way. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12821

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/proxy.js	View		3 chunks	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 1 month ago (2012-10-25 15:04:15 UTC) #2

LGTM (if comment is addressed).

https://codereview.chromium.org/11274047/diff/1/src/proxy.js
File src/proxy.js (right):

https://codereview.chromium.org/11274047/diff/1/src/proxy.js#newcode65
src/proxy.js:65: %InstallFunctions($Proxy, DONT_ENUM, [
Change this to not use a natives syntax runtime call. Also you could prepend a
call to %CheckIsBootstrapping() and put it into a separate setup method. That
would be in line with the way we set up other builtin objects.

Expand Messages | Collapse Messages