Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 11274047: Set up Proxy methods the proper way. (Closed)

Created:
5 years, 1 month ago by rossberg
Modified:
5 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Set up Proxy methods the proper way. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12821

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/proxy.js View 3 chunks +6 lines, -2 lines 1 comment Download
Trybot results:

Messages

Total messages: 2 (0 generated)
rossberg
5 years, 1 month ago (2012-10-25 14:24:07 UTC) #1
Michael Starzinger
5 years, 1 month ago (2012-10-25 15:04:15 UTC) #2
LGTM (if comment is addressed).

https://codereview.chromium.org/11274047/diff/1/src/proxy.js
File src/proxy.js (right):

https://codereview.chromium.org/11274047/diff/1/src/proxy.js#newcode65
src/proxy.js:65: %InstallFunctions($Proxy, DONT_ENUM, [
Change this to not use a natives syntax runtime call. Also you could prepend a
call to %CheckIsBootstrapping() and put it into a separate setup method. That
would be in line with the way we set up other builtin objects.

Powered by Google App Engine
This is Rietveld efc10ee0f