Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1127393005: remove rollback to xmpp when GCM disabled (Closed)

Created:
5 years, 7 months ago by Gang Wu
Modified:
5 years, 7 months ago
Reviewers:
pavely
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not let the invalidations service to fall back to XMPP if GCM is disabled, since we already finished traansite from GCM to XMPP, and XMPP do not have prepare for such load spike. Since Sync have backoff mechanism, so if GCM server some how disabled, sync will retry it later. BUG=479300 Committed: https://crrev.com/bbe31010f9cd16c5c8dc659ce7d9598f0906b7e5 Cr-Commit-Position: refs/heads/master@{#330564}

Patch Set 1 #

Patch Set 2 : update unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M chrome/browser/invalidation/ticl_profile_settings_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Gang Wu
please take a look.
5 years, 7 months ago (2015-05-13 18:16:08 UTC) #2
pavely
lgtm
5 years, 7 months ago (2015-05-13 21:19:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127393005/10002
5 years, 7 months ago (2015-05-19 17:26:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:10002)
5 years, 7 months ago (2015-05-19 18:22:21 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 18:23:56 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bbe31010f9cd16c5c8dc659ce7d9598f0906b7e5
Cr-Commit-Position: refs/heads/master@{#330564}

Powered by Google App Engine
This is Rietveld 408576698