Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2571)

Unified Diff: chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc

Issue 1127393005: remove rollback to xmpp when GCM disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update unittest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/invalidation/ticl_profile_settings_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc
diff --git a/chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc b/chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc
index 7d62b4cdc0825f6b2773f2f99033478eded99cc5..2deed93a17289467396f91e0c59560c7189bde36 100644
--- a/chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc
+++ b/chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc
@@ -92,16 +92,16 @@ TEST_F(TiclProfileSettingsProviderTest, ChannelSelectionTest) {
prefs->SetBoolean(prefs::kInvalidationServiceUseGCMChannel, true);
EXPECT_EQ(TiclInvalidationService::GCM_NETWORK_CHANNEL, GetNetworkChannel());
+ // If invalidation channel setting says use GCM but GCM is not enabled, do not
+ // fall back to push channel.
+ prefs->SetBoolean(gcm::prefs::kGCMChannelStatus, false);
+ prefs->SetBoolean(prefs::kInvalidationServiceUseGCMChannel, true);
+ EXPECT_EQ(TiclInvalidationService::GCM_NETWORK_CHANNEL, GetNetworkChannel());
+
// If invalidation channel setting is set to false, fall back to push channel.
prefs->SetBoolean(gcm::prefs::kGCMChannelStatus, true);
prefs->SetBoolean(prefs::kInvalidationServiceUseGCMChannel, false);
EXPECT_EQ(TiclInvalidationService::PUSH_CLIENT_CHANNEL, GetNetworkChannel());
-
- // If invalidation channel setting says use GCM but GCM is not enabled, fall
- // back to push channel.
- prefs->SetBoolean(gcm::prefs::kGCMChannelStatus, false);
- prefs->SetBoolean(prefs::kInvalidationServiceUseGCMChannel, true);
- EXPECT_EQ(TiclInvalidationService::PUSH_CLIENT_CHANNEL, GetNetworkChannel());
}
} // namespace invalidation
« no previous file with comments | « chrome/browser/invalidation/ticl_profile_settings_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698