Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1127353004: Revert of Don't create a sync node when updating an URL that wasn't typed. (Closed)

Created:
5 years, 7 months ago by pneubeck (no reviews)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't create a sync node when updating an URL that wasn't typed. (patchset #1 id:1 of https://codereview.chromium.org/1126633005/) Reason for revert: Suspected to cause failure of MigrationSingleClientTest.AllTypesIndividually on Linux GN: https://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28301 Original issue's description: > Don't create a sync node when updating an URL that wasn't typed. > > TypedUrlChangeProcessor is a HistoryService observer and gets notified > about changes to all addresses, not just typed ones. This means that > when HistoryService::SetPageTitle() is called for a non-typed URL, > TypedUrlChangeProcessor::OnURLsModified() will be triggered and, > consequently, TypedUrlChangeProcessor::CreateOrUpdateSyncNode(). > As the name suggests, if the modified node was not previously present > (because it was filtered out by ShouldSyncVisit() in OnURLVisited()), > it would be created. > End effect was that *all* URLs that had their title updated (which means > every page that has a <title> tag) were synced, even if they were not typed. > > The solution is to return early in CreateOrUpdateSyncNode() if we detect > that the URL in question has no typed visits. > > (Caused by https://codereview.chromium.org/1087773002/) > > BUG= > > Committed: https://crrev.com/3be1b71d63be98a42c0e98673ff35fcd4fc738ab > Cr-Commit-Position: refs/heads/master@{#329370} TBR=maniscalco@chromium.org,pvalenzuela@chromium.org,mpawlowski@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ebb18035affaa9555dd56e0ac9ab1daf61c64916 Cr-Commit-Position: refs/heads/master@{#329396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -59 lines) Patch
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pneubeck (no reviews)
Created Revert of Don't create a sync node when updating an URL that wasn't typed.
5 years, 7 months ago (2015-05-12 13:16:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127353004/1
5 years, 7 months ago (2015-05-12 13:17:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 13:17:44 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 13:18:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebb18035affaa9555dd56e0ac9ab1daf61c64916
Cr-Commit-Position: refs/heads/master@{#329396}

Powered by Google App Engine
This is Rietveld 408576698