Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1127313012: Update CJK monospace font preferences to Noto Sans Mono CJK (Closed)

Created:
5 years, 7 months ago by jungshik at Google
Modified:
5 years, 7 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update CJK monospace font preferences to Noto Sans Mono CJK Now that we have 'Noto Sans Mono CJK {JP,KR,SC,TC}', we'd better set them to the default monospace fonts for CJK. Two related CLs: https://codereview.chromium.org/1134853002 https://chromium-review.googlesource.com/#/c/269899/ BUG=486164 TEST=The following uses Noto Sans Mono CJK JP instead of Motoya data:text/html,<span lang="ja" style="font-family: monospace">ABC123</span> Committed: https://crrev.com/ab348a3295ec6ffb7c5f472fd4b26687cee1e011 Cr-Commit-Position: refs/heads/master@{#330141}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
jungshik at Google
PTAL, thanks.
5 years, 7 months ago (2015-05-12 18:34:27 UTC) #2
Daniel Erat
lgtm
5 years, 7 months ago (2015-05-13 02:33:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127313012/1
5 years, 7 months ago (2015-05-15 17:58:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 18:33:02 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 18:34:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab348a3295ec6ffb7c5f472fd4b26687cee1e011
Cr-Commit-Position: refs/heads/master@{#330141}

Powered by Google App Engine
This is Rietveld 408576698