Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1134853002: Make Noto Sans Mono CJK JP an alias to MS Gothic (Closed)

Created:
5 years, 7 months ago by jungshik at Google
Modified:
5 years, 7 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org, Daniel Erat, behdad
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make Noto Sans Mono CJK JP an alias to MS Gothic This CL works together with the following CrOS CL: https://chromium-review.googlesource.com/#/c/269899/ BUG=chromium:486164 TEST=With the above CrOS CL, 'MS Gothic' in CSS is replaced by 'Noto Sans Mono CJK JP'. Committed: https://skia.googlesource.com/skia/+/dd4e56849ee832c862314744d60e669a265eaacc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ports/SkFontConfigInterface_direct.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jungshik at Google
Can you take a look? Thanks
5 years, 7 months ago (2015-05-08 23:29:04 UTC) #2
jungshik at Google
Ben, can you take a look? Fontconfig appears to be adding a way to distinguish ...
5 years, 7 months ago (2015-05-11 23:27:20 UTC) #4
jungshik at Google
What I had in mind is this bug (we wanted this for a long time ...
5 years, 7 months ago (2015-05-11 23:29:54 UTC) #5
bungeman-skia
On 2015/05/11 23:29:54, Jungshik at google wrote: > What I had in mind is this ...
5 years, 7 months ago (2015-05-12 13:23:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134853002/1
5 years, 7 months ago (2015-05-12 18:33:31 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 19:08:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dd4e56849ee832c862314744d60e669a265eaacc

Powered by Google App Engine
This is Rietveld 408576698