Source/core/svg/animation/SVGSMILElement.cpp - Issue 1127313007: SVG animate element's begin/end attribute set by js, should animate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 1127313007: SVG animate element's begin/end attribute set by js, should animate. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed testRunner from Layout test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/animation/SVGSMILElement.cpp

diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp

index 719cd493840b94a7801b10273ec43467b5cb4cea..9df8b9a6df64aab2f0d3831e17e582288e38fbfb 100644

--- a/Source/core/svg/animation/SVGSMILElement.cpp

+++ b/Source/core/svg/animation/SVGSMILElement.cpp

@@ -557,6 +557,7 @@ void SVGSMILElement::svgAttributeChanged(const QualifiedName& attrName)

clearAnimatedType();

} else if (attrName == SVGNames::beginAttr || attrName == SVGNames::endAttr) {

if (inDocument()) {

+ connectEventBaseConditions();

if (attrName == SVGNames::beginAttr)

beginListChanged(elapsed());

else if (attrName == SVGNames::endAttr)

« no previous file with comments | « LayoutTests/svg/animations/animation-begin-change-js.html ('k') | no next file » | no next file with comments »