Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 1127313007: SVG animate element's begin/end attribute set by js, should animate. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed testRunner from Layout test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/svg/animations/animation-begin-change-js.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
550 m_cachedMax = invalidCachedTime; 550 m_cachedMax = invalidCachedTime;
551 else if (attrName == SVGNames::attributeNameAttr) 551 else if (attrName == SVGNames::attributeNameAttr)
552 setAttributeName(constructQualifiedName(this, fastGetAttribute(SVGNames: :attributeNameAttr))); 552 setAttributeName(constructQualifiedName(this, fastGetAttribute(SVGNames: :attributeNameAttr)));
553 else if (attrName.matches(XLinkNames::hrefAttr)) { 553 else if (attrName.matches(XLinkNames::hrefAttr)) {
554 SVGElement::InvalidationGuard invalidationGuard(this); 554 SVGElement::InvalidationGuard invalidationGuard(this);
555 buildPendingResource(); 555 buildPendingResource();
556 if (m_targetElement) 556 if (m_targetElement)
557 clearAnimatedType(); 557 clearAnimatedType();
558 } else if (attrName == SVGNames::beginAttr || attrName == SVGNames::endAttr) { 558 } else if (attrName == SVGNames::beginAttr || attrName == SVGNames::endAttr) {
559 if (inDocument()) { 559 if (inDocument()) {
560 connectEventBaseConditions();
560 if (attrName == SVGNames::beginAttr) 561 if (attrName == SVGNames::beginAttr)
561 beginListChanged(elapsed()); 562 beginListChanged(elapsed());
562 else if (attrName == SVGNames::endAttr) 563 else if (attrName == SVGNames::endAttr)
563 endListChanged(elapsed()); 564 endListChanged(elapsed());
564 } 565 }
565 } else { 566 } else {
566 SVGElement::svgAttributeChanged(attrName); 567 SVGElement::svgAttributeChanged(attrName);
567 return; 568 return;
568 } 569 }
569 570
(...skipping 783 matching lines...) Expand 10 before | Expand all | Expand 10 after
1353 visitor->trace(m_targetElement); 1354 visitor->trace(m_targetElement);
1354 visitor->trace(m_timeContainer); 1355 visitor->trace(m_timeContainer);
1355 visitor->trace(m_conditions); 1356 visitor->trace(m_conditions);
1356 visitor->trace(m_syncBaseDependents); 1357 visitor->trace(m_syncBaseDependents);
1357 #endif 1358 #endif
1358 SVGElement::trace(visitor); 1359 SVGElement::trace(visitor);
1359 SVGTests::trace(visitor); 1360 SVGTests::trace(visitor);
1360 } 1361 }
1361 1362
1362 } // namespace blink 1363 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/svg/animations/animation-begin-change-js.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698