Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1127293003: Update mojo sdk to rev f84766d3b6420b7cf6a113d9d65d73cb5fe18d90 (Closed)

Created:
5 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 7 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev f84766d3b6420b7cf6a113d9d65d73cb5fe18d90 Noteworthy in this roll is that InterfacePtrs may no longer be bound-to or passed-as simple pipe handles, but instead as InterfacePtrInfos. This requires updating several call sites of InterfacePtr's Bind and PassMessagePipe. BUG= TBR=ben@chromium.org Committed: https://crrev.com/d24477996ef10584ced040a13f82e7c7dc0216b1 Cr-Commit-Position: refs/heads/master@{#329783}

Patch Set 1 #

Patch Set 2 : Chrome changes #

Patch Set 3 : Fix mojo_public.gyp #

Patch Set 4 : Merge IPC fixes #

Total comments: 2

Patch Set 5 : le formatting #

Patch Set 6 : merge #

Patch Set 7 : Remove WeakPtr from IPCSupportInitializer #

Patch Set 8 : Roll mojo/android as well; add missing GYP dependency #

Patch Set 9 : Revert bad gyp #

Patch Set 10 : merge #

Patch Set 11 : correct dependencies everywhere but java #

Patch Set 12 : GYP fixed for real. -_- #

Patch Set 13 : merge #

Patch Set 14 : 1. fix gyp; 2. try not to cry; 3. cry a lot. #

Patch Set 15 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2862 lines, -1278 lines) Patch
M components/html_viewer/web_layer_tree_view_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/surfaces/display_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -2 lines 0 comments Download
M mandoline/ui/aura/surface_binding.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/javatests/AndroidManifest.xml View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTestUtils.java View 1 2 3 4 5 6 7 2 chunks +14 lines, -1 line 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsVersioningTest.java View 1 2 3 4 5 6 7 11 chunks +21 lines, -9 lines 0 comments Download
A mojo/android/javatests/src/org/chromium/mojo/bindings/InterfaceControlMessageTest.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +129 lines, -0 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/InterfacesTest.java View 1 2 3 4 5 6 7 4 chunks +8 lines, -14 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/ReadAndDispatchMessageTest.java View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/RouterTest.java View 1 2 3 4 5 6 7 4 chunks +117 lines, -16 lines 0 comments Download
M mojo/application/application_test_base_chromium.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M mojo/runner/child_process_host.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M mojo/runner/shell_test_base.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M mojo/shell/application_manager.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M mojo/shell/application_manager.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mojo/mojo_public.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +52 lines, -5 lines 0 comments Download
M third_party/mojo/mojom_bindings_generator.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mojo/mojom_bindings_generator_explicit.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/application_connection.h View 4 chunks +19 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/application_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/connect.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/lib/application_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/cpp/application/lib/interface_factory_connector.h View 1 chunk +37 lines, -0 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/service_connector.h View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/service_connector.cc View 1 chunk +0 lines, -18 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/application/lib/service_connector_registry.h View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/application/lib/service_connector_registry.cc View 1 chunk +59 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/lib/service_provider_impl.cc View 2 chunks +10 lines, -26 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/lib/service_registry.h View 4 chunks +9 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/lib/service_registry.cc View 3 chunks +15 lines, -36 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/application/service_connector.h View 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/service_provider_impl.h View 2 chunks +11 lines, -14 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/tests/service_registry_unittest.cc View 2 chunks +18 lines, -13 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/interface_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h View 4 chunks +24 lines, -28 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/interface_request.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/bindings_internal.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/bindings_serialization.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/bindings_serialization.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/connector.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/control_message_handler.h View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/control_message_handler.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/control_message_proxy.h View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/control_message_proxy.cc View 1 chunk +104 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 2 chunks +28 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/map_data_internal.h View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/map_serialization.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/message_builder.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/message_header_validator.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_util.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/message.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn View 3 chunks +52 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/tests/constant_unittest.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 7 chunks +69 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/union_unittest.cc View 9 chunks +225 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/tests/versioning_apptest.cc View 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +125 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/logging.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/system/macros.h View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/codec.dart View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/message.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/application/application_impl.go View 3 chunks +11 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/application/connection.go View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/connector.go View 4 chunks +22 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/decoder.go View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/encoder.go View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/message.go View 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/router.go View 5 chunks +5 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/util.go View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/interface_control_messages.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/boundscheck_msghdr_no_such_method.data View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_incomplete_struct.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_invalid_flag_combo.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_missing_request_id.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_no_such_method.data View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_num_bytes_huge.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_num_bytes_less_than_min_requirement.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_num_bytes_version_mismatch_1.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_msghdr_num_bytes_version_mismatch_2.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_incomplete_struct.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_incomplete_struct_header.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_invalid_request_flags.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_invalid_request_flags2.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_struct_num_bytes_huge.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_struct_num_bytes_less_than_min_requirement.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_struct_num_bytes_less_than_struct_header.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_good.data View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_good_non_unique_keys.data View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_null_keys.data View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_null_values.data View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_one_null_key.data View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_unequal_array_size.data View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version0.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version1.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version2.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version3.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version_newer_than_known_1.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version_newer_than_known_2.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_num_bytes_version_mismatch_1.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_num_bytes_version_mismatch_2.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd12_invalid_request_flags.data View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd13_good_1.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd13_good_2.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd1_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd1_misaligned_struct.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd1_struct_pointer_overflow.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd1_unexpected_null_struct.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd2_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd2_multiple_pointers_to_same_struct.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd2_overlapped_objects.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd2_wrong_layout_order.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_array_num_bytes_huge.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_array_num_bytes_less_than_array_header.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_array_num_bytes_less_than_necessary_size.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_array_pointer_overflow.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_incomplete_array.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_incomplete_array_header.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_misaligned_array.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_unexpected_null_array.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd4_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd4_multiple_pointers_to_same_array.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd4_overlapped_objects.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd4_wrong_layout_order.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_handle_out_of_range.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_multiple_handles_with_same_value_1.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_multiple_handles_with_same_value_2.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_unexpected_invalid_handle.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_wrong_handle_order.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd6_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd6_nested_array_num_bytes_less_than_necessary_size.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd7_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd7_unexpected_null_fixed_array.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd7_unmatched_array_elements.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd7_unmatched_array_elements_nested.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_array_num_bytes_overflow.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_unexpected_null_array.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_unexpected_null_string.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd9_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd9_good_null_array.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd9_unexpected_null_array.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/integration_intf_resp_mthd0_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/integration_intf_resp_mthd0_unexpected_array_header.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/integration_intf_rqst_mthd0_good.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/integration_intf_rqst_mthd0_unexpected_struct_header.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/integration_msghdr_invalid_flags.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/resp_boundscheck_msghdr_no_such_method.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/resp_conformance_msghdr_invalid_response_flags1.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/resp_conformance_msghdr_invalid_response_flags2.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/data/validation/resp_conformance_msghdr_no_such_method.data View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/sample_service.mojom View 2 chunks +0 lines, -10 lines 0 comments Download
A third_party/mojo/src/mojo/public/interfaces/bindings/tests/test_constants.mojom View 1 chunk +53 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/test_structs.mojom View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/test_unions.mojom View 3 chunks +14 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/interfaces/bindings/tests/versioning_test_client.mojom View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/interfaces/bindings/tests/versioning_test_service.mojom View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/application/src/org/chromium/mojo/application/ApplicationDelegate.java View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/application/src/org/chromium/mojo/application/ApplicationImpl.java View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Connector.java View 4 chunks +10 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Encoder.java View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java View 8 chunks +89 lines, -3 lines 0 comments Download
A third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceControlMessagesHelper.java View 1 chunk +89 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/MessageHeader.java View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/RouterImpl.java View 7 chunks +71 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Struct.java View 2 chunks +17 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/js/codec.js View 4 chunks +4 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/js/codec_unittests.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/js/struct_unittests.js View 3 chunks +16 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/js/validator.js View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/python/BUILD.gn View 4 chunks +34 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/python/mojo_bindings/descriptor.py View 2 chunks +13 lines, -6 lines 0 comments Download
A + third_party/mojo/src/mojo/public/python/mojo_bindings/interface_reflection.py View 15 chunks +134 lines, -235 lines 0 comments Download
M third_party/mojo/src/mojo/public/python/mojo_bindings/messaging.py View 3 chunks +12 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/python/mojo_bindings/reflection.py View 4 chunks +3 lines, -357 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/NETWORK_SERVICE_VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl View 2 chunks +11 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 8 chunks +31 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 2 chunks +10 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 4 chunks +36 lines, -28 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl View 5 chunks +10 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl View 2 chunks +6 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 3 chunks +26 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl View 2 chunks +22 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 1 chunk +10 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl View 5 chunks +6 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/struct.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 4 chunks +13 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 10 chunks +21 lines, -15 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_dart_generator.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_go_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_java_generator.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom.gni View 8 chunks +23 lines, -23 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py View 5 chunks +26 lines, -15 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/gn/unzip.py View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Ken Rockot(use gerrit already)
Scott, could you please take a look at the non-third_party, non-ipc bits of this CL? ...
5 years, 7 months ago (2015-05-08 17:53:37 UTC) #5
sky
I'm not familiar with the ipc code to do it justice. Can you find another ...
5 years, 7 months ago (2015-05-08 19:08:03 UTC) #6
Ken Rockot(use gerrit already)
Thanks! I've asked morrita to review the IPC CL. The IPC changes here are just ...
5 years, 7 months ago (2015-05-08 19:12:48 UTC) #7
Ken Rockot(use gerrit already)
+jam: Still blocking on the GYP dependency issue if you have any ideas
5 years, 7 months ago (2015-05-12 17:39:33 UTC) #9
Ken Rockot(use gerrit already)
Well, only Android is broken now and it repros locally, so at least we've got ...
5 years, 7 months ago (2015-05-13 02:09:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127293003/340001
5 years, 7 months ago (2015-05-14 00:11:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63501)
5 years, 7 months ago (2015-05-14 00:24:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127293003/360001
5 years, 7 months ago (2015-05-14 00:54:36 UTC) #19
commit-bot: I haz the power
Committed patchset #15 (id:360001)
5 years, 7 months ago (2015-05-14 02:07:25 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 02:08:10 UTC) #21
Message was sent while issue was closed.
Patchset 15 (id:??) landed as
https://crrev.com/d24477996ef10584ced040a13f82e7c7dc0216b1
Cr-Commit-Position: refs/heads/master@{#329783}

Powered by Google App Engine
This is Rietveld 408576698