third_party/mojo/src/mojo/public/go/application/connection.go - Issue 1127293003: Update mojo sdk to rev f84766d3b6420b7cf6a113d9d65d73cb5fe18d90

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/go/application/connection.go

Issue 1127293003: Update mojo sdk to rev f84766d3b6420b7cf6a113d9d65d73cb5fe18d90 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/go/application/application_impl.go ('k') | third_party/mojo/src/mojo/public/go/bindings/connector.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/go/application/connection.go

diff --git a/third_party/mojo/src/mojo/public/go/application/connection.go b/third_party/mojo/src/mojo/public/go/application/connection.go

index 5b2c62998e2f52e1e121fbbafe5efdf07ad22afc..aa9f30beaccea0f7197549bdefd565b495c2fe27 100644

--- a/third_party/mojo/src/mojo/public/go/application/connection.go

+++ b/third_party/mojo/src/mojo/public/go/application/connection.go

@@ -111,8 +111,10 @@ func (c *Connection) ProvideServices(services ...ServiceFactory) *OutgoingConnec

go func() {

for {

if err := c.localServices.ServeRequest(); err != nil {

- // TODO(rogulenko): don't log in case message pipe was closed

- log.Println(err)

+ connectionError, ok := err.(*bindings.ConnectionError)

+ if !ok || !connectionError.Closed() {

+ log.Println(err)

+ }

break

}