chrome/browser/chromeos/file_system_provider/service.cc - Issue 1127283003: Make some file_system_provider_capabilities fields optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/service.cc

Issue 1127283003: Make some file_system_provider_capabilities fields optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed parsing. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/service.cc

diff --git a/chrome/browser/chromeos/file_system_provider/service.cc b/chrome/browser/chromeos/file_system_provider/service.cc

index 6dccf4017bcafd72dd65fb8558cbfeeaec5ef46a..c41b154ea71d83e6afdbe166f29f7bb9f9893d13 100644

--- a/chrome/browser/chromeos/file_system_provider/service.cc

+++ b/chrome/browser/chromeos/file_system_provider/service.cc

@@ -318,11 +318,10 @@ std::vector<ProvidingExtensionInfo> Service::GetProvidingExtensionInfoList()

ProvidingExtensionInfo info;

info.extension_id = extension->id();

info.name = extension->name();

- const extensions::FileSystemProviderCapabilities* capabilities =

+ const auto capabilities =

not at google - send to devlin 2015/05/12 20:52:14 (I preferred it as the actual typename, but whatev

mtomasz 2015/05/13 00:29:42 Done.

extensions::FileSystemProviderCapabilities::Get(extension.get());

- info.capabilities = capabilities

- ? *capabilities

- : extensions::FileSystemProviderCapabilities();

+ DCHECK(capabilities);

+ info.capabilities = *capabilities;

result.push_back(info);

}