chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc - Issue 1127283003: Make some file_system_provider_capabilities fields optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc

Issue 1127283003: Make some file_system_provider_capabilities fields optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed parsing. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/file_system_provider/service.cc ('K') | « chrome/browser/chromeos/file_system_provider/service.cc ('k') | chrome/common/extensions/api/manifest_types.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc

diff --git a/chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc b/chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc

index c3dc906cea8e0dc5f00180483399ce2297e23063..d959ad725e863d39f24e72df7cd3f8f5f3907da3 100644

--- a/chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc

+++ b/chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc

@@ -95,9 +95,14 @@ bool FileSystemProviderCapabilitiesHandler::Parse(Extension* extension,

}

scoped_ptr<FileSystemProviderCapabilities> capabilities(

- new FileSystemProviderCapabilities(idl_capabilities.configurable,

- idl_capabilities.multiple_mounts,

- source));

+ new FileSystemProviderCapabilities(

+ idl_capabilities.configurable.get()

+ ? *idl_capabilities.configurable.get()

+ : false /* false by default */,

+ idl_capabilities.multiple_mounts.get()

+ ? *idl_capabilities.multiple_mounts.get()

+ : false /* false by default */,

+ source));

extension->SetManifestData(manifest_keys::kFileSystemProviderCapabilities,

capabilities.release());