Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 11272035: Add FORMAT_REMAINING_LONG in TimeFormat class to support formatting remaining time in long minute f… (Closed)

Created:
8 years, 1 month ago by jennyz
Modified:
8 years, 1 month ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add FORMAT_REMAINING_LONG in TimeFormat class to support formatting remaining time in long minute format. BUG=157169 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +69 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/time_format.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/time_format.cc View 9 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jennyz
8 years, 1 month ago (2012-10-25 18:18:06 UTC) #1
jungshik at Google
LGTM
8 years, 1 month ago (2012-10-25 18:40:45 UTC) #2
jennyz
sadrul, I discussed with jshin@ and I added FORMAT_REMAINING_LONG to support long minute format for ...
8 years, 1 month ago (2012-10-25 18:43:45 UTC) #3
sadrul
Awesome! Thanks for doing this. LGTM
8 years, 1 month ago (2012-10-25 18:45:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/11272035/1
8 years, 1 month ago (2012-10-25 18:51:36 UTC) #5
commit-bot: I haz the power
Presubmit check for 11272035-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-10-25 18:51:40 UTC) #6
jennyz
8 years, 1 month ago (2012-10-25 18:57:46 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 19:02:27 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698