Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127163004: Delete unused code in chrome/common or mark them as platform specific. (Closed)

Created:
5 years, 7 months ago by Lei Zhang
Modified:
5 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete unused code in chrome/common or mark them as platform specific. Found by Scythe. Committed: https://crrev.com/d6396d89c405bb76aa0ec7331c67e3e4077558ff Cr-Commit-Position: refs/heads/master@{#329230}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -292 lines) Patch
M chrome/browser/first_run/first_run.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_constants.h View 4 chunks +11 lines, -7 lines 0 comments Download
M chrome/common/chrome_constants.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M chrome/common/chrome_switches.h View 10 chunks +17 lines, -18 lines 0 comments Download
M chrome/common/chrome_switches.cc View 15 chunks +43 lines, -55 lines 0 comments Download
M chrome/common/env_vars.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/env_vars.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/local_discovery/service_discovery_client_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 18 chunks +22 lines, -29 lines 0 comments Download
M chrome/common/pref_names.cc View 24 chunks +22 lines, -77 lines 0 comments Download
M chrome/common/tts_utterance_request.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/tts_utterance_request.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/url_constants.h View 18 chunks +23 lines, -34 lines 0 comments Download
M chrome/common/url_constants.cc View 20 chunks +24 lines, -31 lines 0 comments Download
M chrome/installer/util/util_constants.h View 1 chunk +6 lines, -0 lines 1 comment Download
M chrome/installer/util/util_constants.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Lei Zhang
5 years, 7 months ago (2015-05-07 20:54:46 UTC) #4
erikwright (departed)
This looks fine to me. I'm not an owner for anything this touches, though. For ...
5 years, 7 months ago (2015-05-11 18:24:00 UTC) #5
Lei Zhang
grt: want to stamp this CL?
5 years, 7 months ago (2015-05-11 18:37:25 UTC) #7
grt (UTC plus 2)
chrome/installer/util/* lgtm the rest looks okay, but I can't say much more than rubberstamp there. ...
5 years, 7 months ago (2015-05-11 19:43:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127163004/40001
5 years, 7 months ago (2015-05-11 19:45:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/70661)
5 years, 7 months ago (2015-05-11 19:53:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127163004/40001
5 years, 7 months ago (2015-05-11 20:40:32 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 7 months ago (2015-05-11 21:08:57 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 21:10:17 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d6396d89c405bb76aa0ec7331c67e3e4077558ff
Cr-Commit-Position: refs/heads/master@{#329230}

Powered by Google App Engine
This is Rietveld 408576698