Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2478)

Unified Diff: chrome/common/chrome_constants.cc

Issue 1127163004: Delete unused code in chrome/common or mark them as platform specific. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_constants.cc
diff --git a/chrome/common/chrome_constants.cc b/chrome/common/chrome_constants.cc
index db0d5cbd95ac34f18133bfdbc60322ea4baed3fc..bab2b24b06a24be4b1affb09feebf81dae0a8074 100644
--- a/chrome/common/chrome_constants.cc
+++ b/chrome/common/chrome_constants.cc
@@ -21,7 +21,9 @@
namespace chrome {
+#if defined(OS_WIN)
const char kChromeVersionEnvVar[] = "CHROME_VERSION";
+#endif
// The following should not be used for UI strings; they are meant
// for system strings only. UI changes should be made in the GRD.
@@ -124,17 +126,16 @@ const char* const kHelperFlavorSuffixes[] = {
#endif // OS_MACOSX
#if defined(OS_WIN)
+const base::FilePath::CharType kBrowserResourcesDll[] = FPL("chrome.dll");
const base::FilePath::CharType kMetroDriverDll[] = FPL("metro_driver.dll");
-const wchar_t kStatusTrayWindowClass[] = L"Chrome_StatusTrayWindow";
+const base::FilePath::CharType kStatusTrayWindowClass[] =
+ FPL("Chrome_StatusTrayWindow");
#endif // defined(OS_WIN)
-const wchar_t kCrashReportLog[] = L"Reported Crashes.txt";
-const wchar_t kTestingInterfaceDLL[] = L"testing_interface.dll";
const char kInitialProfile[] = "Default";
const char kMultiProfileDirPrefix[] = "Profile ";
const base::FilePath::CharType kGuestProfileDir[] = FPL("Guest Profile");
const base::FilePath::CharType kSystemProfileDir[] = FPL("System Profile");
-const wchar_t kBrowserResourcesDll[] = L"chrome.dll";
// filenames
const base::FilePath::CharType kAffiliationDatabaseFileName[] =
@@ -152,15 +153,12 @@ const base::FilePath::CharType kExtensionsCookieFilename[] =
FPL("Extension Cookies");
const base::FilePath::CharType kFirstRunSentinel[] = FPL("First Run");
const base::FilePath::CharType kGCMStoreDirname[] = FPL("GCM Store");
-const base::FilePath::CharType kJumpListIconDirname[] = FPL("JumpListIcons");
const base::FilePath::CharType kLocalStateFilename[] = FPL("Local State");
const base::FilePath::CharType kLocalStorePoolName[] = FPL("LocalStorePool");
const base::FilePath::CharType kLoginDataFileName[] = FPL("Login Data");
const base::FilePath::CharType kMediaCacheDirname[] = FPL("Media Cache");
const base::FilePath::CharType kNetworkPersistentStateFilename[] =
FPL("Network Persistent State");
-const base::FilePath::CharType kNewTabThumbnailsFilename[] =
- FPL("Top Thumbnails");
const base::FilePath::CharType kPreferencesFilename[] = FPL("Preferences");
const base::FilePath::CharType kProtectedPreferencesFilenameDeprecated[] =
FPL("Protected Preferences");
@@ -180,11 +178,13 @@ const base::FilePath::CharType kSingletonSocketFilename[] =
FPL("SingletonSocket");
const base::FilePath::CharType kSupervisedUserSettingsFilename[] =
FPL("Managed Mode Settings");
-const base::FilePath::CharType kSyncCredentialsFilename[] =
- FPL("Sync Credentials");
const base::FilePath::CharType kThemePackFilename[] = FPL("Cached Theme.pak");
const base::FilePath::CharType kWebAppDirname[] = FPL("Web Applications");
+#if defined(OS_WIN)
+const base::FilePath::CharType kJumpListIconDirname[] = FPL("JumpListIcons");
+#endif
+
// File name of the Pepper Flash plugin on different platforms.
const base::FilePath::CharType kPepperFlashPluginFilename[] =
#if defined(OS_MACOSX)
@@ -196,7 +196,9 @@ const base::FilePath::CharType kPepperFlashPluginFilename[] =
#endif
// directory names
+#if defined(OS_WIN)
const wchar_t kUserDataDirname[] = L"User Data";
+#endif
const float kMaxShareOfExtensionProcesses = 0.30f;

Powered by Google App Engine
This is Rietveld 408576698