Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1127163003: Merge to XFA: Fix a regression with cut off images. (Closed)

Created:
5 years, 7 months ago by Lei Zhang
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix a regression with cut off images. This regressed in commit 3f41851 due to shadow variables. BUG=478164 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1101443004 (cherry picked from commit 97d10aff654e42c1b7c3d2abf33fbcf8d341799e) Committed: https://pdfium.googlesource.com/pdfium/+/903e03a03ad4526252874d8ba15258e7c2955739

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
5 years, 7 months ago (2015-05-06 19:38:45 UTC) #1
Tom Sepez
lgtm
5 years, 7 months ago (2015-05-06 19:45:46 UTC) #2
Lei Zhang
5 years, 7 months ago (2015-05-06 21:00:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
903e03a03ad4526252874d8ba15258e7c2955739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698