Issue 1101443004: Fix a regression with cut off images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1101443004: Fix a regression with cut off images. (Closed)

Created:
5 years, 8 months ago by Lei Zhang

Modified:
5 years, 8 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a regression with cut off images. This regressed in commit 3f41851 due to shadow variables. BUG=478164 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/97d10aff654e42c1b7c3d2abf33fbcf8d341799e

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

I'll roll DEPS once the test case update gets committed.

5 years, 8 months ago (2015-04-22 01:04:43 UTC) #2

Lei Zhang

5 years, 8 months ago (2015-04-22 01:35:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
97d10aff654e42c1b7c3d2abf33fbcf8d341799e (presubmit successful).