Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127133006: Extract InstallVerifier from ExtensionSystem. (Closed)

Created:
5 years, 7 months ago by juncai
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract InstallVerifier from ExtensionSystem. This patch removes install_verifier accessor from ExtensionSystem. It can be its own browser context keyed service. It can be built by its new factory. Committed: https://crrev.com/33e4621016bbfb1cfa822efc2fc0e519da7a8e18 Cr-Commit-Position: refs/heads/master@{#330411}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -66 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.h View 1 4 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 4 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/extensions/install_verifier.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/install_verifier.cc View 2 chunks +7 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/install_verifier_factory.h View 2 chunks +12 lines, -11 lines 0 comments Download
A + chrome/browser/extensions/install_verifier_factory.cc View 1 2 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 1 2 3 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/extensions_metrics_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/extension_system.h View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/browser/mock_extension_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/mock_extension_system.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_extension_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_extension_system.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
juncai
Alexei: please review chrome/browser/metrics/extensions_metrics_provider.cc Lei: please review chrome/chrome_browser_extensions.gypi reillyg: please review the remaining
5 years, 7 months ago (2015-05-15 23:02:48 UTC) #2
Lei Zhang
On 2015/05/15 23:02:48, juncai wrote: > Lei: please review chrome/chrome_browser_extensions.gypi lgtm with reillyg's approval.
5 years, 7 months ago (2015-05-15 23:07:22 UTC) #3
Reilly Grant (use Gerrit)
lgtm with one nit https://codereview.chromium.org/1127133006/diff/20001/chrome/browser/extensions/test_extension_system.h File chrome/browser/extensions/test_extension_system.h (right): https://codereview.chromium.org/1127133006/diff/20001/chrome/browser/extensions/test_extension_system.h#newcode102 chrome/browser/extensions/test_extension_system.h:102: scoped_ptr<InstallVerifier> install_verifier_; Remove this line ...
5 years, 7 months ago (2015-05-18 18:26:30 UTC) #4
juncai
Hi Reilly, please review the change. https://codereview.chromium.org/1127133006/diff/20001/chrome/browser/extensions/test_extension_system.h File chrome/browser/extensions/test_extension_system.h (right): https://codereview.chromium.org/1127133006/diff/20001/chrome/browser/extensions/test_extension_system.h#newcode102 chrome/browser/extensions/test_extension_system.h:102: scoped_ptr<InstallVerifier> install_verifier_; On ...
5 years, 7 months ago (2015-05-18 20:10:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127133006/40001
5 years, 7 months ago (2015-05-18 20:41:04 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-18 20:48:50 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/33e4621016bbfb1cfa822efc2fc0e519da7a8e18 Cr-Commit-Position: refs/heads/master@{#330411}
5 years, 7 months ago (2015-05-18 22:42:51 UTC) #10
Alexei Svitkine (slow)
5 years, 7 months ago (2015-05-19 16:30:41 UTC) #11
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698