chrome/browser/extensions/extension_service.cc - Issue 1127133006: Extract InstallVerifier from ExtensionSystem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 1127133006: Extract InstallVerifier from ExtensionSystem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 54f4dee21782ad230c940a65073a1b34e5bc41d8..c18d61296ce62abf0948f58c576980328dfb6e8b 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -742,7 +742,7 @@ bool ExtensionService::UninstallExtension(

extension.get(), is_ready());

}

- system_->install_verifier()->Remove(extension->id());

+ InstallVerifier::Get(GetBrowserContext())->Remove(extension->id());

UMA_HISTOGRAM_ENUMERATION("Extensions.UninstallType",

extension->GetType(), 100);

@@ -1913,7 +1913,7 @@ void ExtensionService::AddNewOrUpdatedExtension(

extension, initial_state, page_ordinal, install_flags, install_parameter);

delayed_installs_.Remove(extension->id());

if (InstallVerifier::NeedsVerification(*extension))

- system_->install_verifier()->VerifyExtension(extension->id());

+ InstallVerifier::Get(GetBrowserContext())->VerifyExtension(extension->id());

const Extension* old = GetInstalledExtension(extension->id());

if (extensions::AppDataMigrator::NeedsMigration(old, extension)) {