Issue 11271026: Fix dump_dependency_json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11271026: Fix dump_dependency_json. (Closed)

Created:
8 years, 1 month ago by Torne

Modified:
8 years, 1 month ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix dump_dependency_json. dump_dependency_json needs to define CONFIGURATION_NAME like the other generators, otherwise it fails when run on real projects. Committed: https://code.google.com/p/gyp/source/detail?r=1524

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pylib/gyp/generator/dump_dependency_json.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Torne

Found this while trying to track down a dependency problem :)

8 years, 1 month ago (2012-10-25 15:51:02 UTC) #1

Nico

8 years, 1 month ago (2012-10-25 19:33:44 UTC) #2

lgtm

This used to not be necessary before the android and ios ports landed (just fyi,
not complaining).

Expand Messages | Collapse Messages