Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1127093002: Combine the three patches below for try bot testing: (Closed)

Created:
5 years, 7 months ago by davve
Modified:
5 years, 7 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Combine the three patches below for try bot testing: Don't conflate intrinsic width and height with logical width and height This is wrong in vertical writing mode and shouldn't be necessary. The intrinsic dimensions are propagated from attributes to properties in SVGSVGElement::collectStyleForPresentationAttribute(). BUG=484425 Return vertical writing mode aware intrinsic information for SVG Values returned from computeIntrinsicRatioInformation are assumed to be logical, i.e. they should take writing mode into consideration. BUG=484425 Add tests for SVG sizing inside vertical writing mode BUG=484425

Patch Set 1 #

Patch Set 2 : Remove now unused method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -17 lines) Patch
A LayoutTests/svg/in-html/sizing/svg-inline-vertical.html View 1 chunk +40 lines, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGRoot.cpp View 1 5 chunks +5 lines, -17 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698