Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1127023002: Oilpan: address ScrollableArea-induced build breakage from r194957. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, bokan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: address ScrollableArea-induced build breakage from r194957. ScrollableArea is not an Oilpan allocated mixin currently, so in order to support the assumption of RootFrameViewport that all ScrollableAreas are allocated the same way, pull PinchViewport off the Oilpan heap (PinchViewport being the only ScrollableArea that was Oilpan controlled.) This is not ideal, but a shorter term measure to unbreak Oilpan builds. Making ScrollableArea a GC mixin would be the longer term solution, but that's not a straightforward task. TBR=oilpan-reviews BUG=443724 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M Source/core/frame/FrameHost.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameHost.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/PinchViewport.h View 2 chunks +8 lines, -7 lines 0 comments Download
M Source/core/frame/PinchViewport.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/frame/RootFrameViewport.h View 3 chunks +7 lines, -9 lines 0 comments Download
M Source/core/frame/RootFrameViewport.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sof
please take a look.
5 years, 7 months ago (2015-05-06 06:11:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127023002/1
5 years, 7 months ago (2015-05-06 06:12:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194964
5 years, 7 months ago (2015-05-06 06:16:06 UTC) #4
haraken
5 years, 7 months ago (2015-05-06 13:57:39 UTC) #5
Message was sent while issue was closed.
LGTM as a short-term fix. Thanks!

Powered by Google App Engine
This is Rietveld 408576698