Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: Source/core/frame/PinchViewport.h

Issue 1127023002: Oilpan: address ScrollableArea-induced build breakage from r194957. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/FrameHost.cpp ('k') | Source/core/frame/PinchViewport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/PinchViewport.h
diff --git a/Source/core/frame/PinchViewport.h b/Source/core/frame/PinchViewport.h
index 8e4b5589c1c4636b6161436ca027cbd45ab343f1..c034a1fc681d0ed8a4423af3eadd0420c82e821c 100644
--- a/Source/core/frame/PinchViewport.h
+++ b/Source/core/frame/PinchViewport.h
@@ -62,14 +62,13 @@ class LocalFrame;
// offset is set through the GraphicsLayer <-> CC sync mechanisms. Its contents is the page's
// main FrameView, which corresponds to the outer viewport. The inner viewport is always contained
// in the outer viewport and can pan within it.
-class CORE_EXPORT PinchViewport final : public NoBaseWillBeGarbageCollectedFinalized<PinchViewport>, public GraphicsLayerClient, public ScrollableArea {
+class CORE_EXPORT PinchViewport final : public GraphicsLayerClient, public ScrollableArea {
public:
- static PassOwnPtrWillBeRawPtr<PinchViewport> create(FrameHost& host)
+ static PassOwnPtr<PinchViewport> create(FrameHost& host)
{
- return adoptPtrWillBeNoop(new PinchViewport(host));
+ return adoptPtr(new PinchViewport(host));
}
virtual ~PinchViewport();
- DECLARE_VIRTUAL_TRACE();
void attachToLayerTree(GraphicsLayer*, GraphicsLayerFactory*);
GraphicsLayer* rootGraphicsLayer()
@@ -204,11 +203,13 @@ private:
FrameHost& frameHost() const
{
- ASSERT(m_frameHost);
- return *m_frameHost;
+ return m_frameHost;
}
- RawPtrWillBeMember<FrameHost> m_frameHost;
+ // TODO(Oilpan): this back reference is safe, but not ideal.
+ // Turning it into a traced Member<> would require moving
+ // ScrollableArea to the heap.
+ FrameHost& m_frameHost;
OwnPtr<GraphicsLayer> m_rootTransformLayer;
OwnPtr<GraphicsLayer> m_innerViewportContainerLayer;
OwnPtr<GraphicsLayer> m_overscrollElasticityLayer;
« no previous file with comments | « Source/core/frame/FrameHost.cpp ('k') | Source/core/frame/PinchViewport.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698