Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 11269063: Fix the NACL_INSTR_* names that I just checked in to NACL_INSTR_ARM_*, as suggested by mseaborn. (Closed)

Created:
8 years, 1 month ago by JF
Modified:
8 years, 1 month ago
Reviewers:
Mark Seaborn, kschimpf
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fix the NACL_INSTR_* names that I just checked in to NACL_INSTR_ARM_*, as suggested by mseaborn. R=mseaborn@chromium.org,kschimpf@chromium.org Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -33 lines) Patch
M src/include/arm_sandbox.h View 3 chunks +12 lines, -12 lines 0 comments Download
M src/trusted/debug_stub/abi.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/service_runtime/arch/arm/nacl_text_pad_test.S View 1 chunk +4 lines, -3 lines 0 comments Download
M src/trusted/service_runtime/arch/arm/sel_ldr_arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/validator_arm/model.h View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/debug_stub/debugger_test.c View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/dynamic_code_loading/dynamic_load_test.c View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/dynamic_code_loading/dyncode_demand_alloc_test.c View 1 chunk +1 line, -1 line 0 comments Download
M tests/dynamic_code_loading/templates_arm.S View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/faulted_thread_queue/faultqueue_test_guest.c View 1 chunk +1 line, -1 line 0 comments Download
M tests/syscall_return_sandboxing/sandboxed_arm.S View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
JF
8 years, 1 month ago (2012-10-26 00:29:23 UTC) #1
Mark Seaborn
LGTM, thanks
8 years, 1 month ago (2012-10-26 01:03:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/jfb@chromium.org/11269063/1
8 years, 1 month ago (2012-10-26 01:11:18 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-10-26 04:53:04 UTC) #4
Change committed as 10107

Powered by Google App Engine
This is Rietveld 408576698