tests/debug_stub/debugger_test.c - Issue 11269063: Fix the NACL_INSTR_* names that I just checked in to NACL_INSTR_ARM_*, as suggested by mseaborn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/debug_stub/debugger_test.c

Issue 11269063: Fix the NACL_INSTR_* names that I just checked in to NACL_INSTR_ARM_*, as suggested by mseaborn. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/debug_stub/debugger_test.c

diff --git a/tests/debug_stub/debugger_test.c b/tests/debug_stub/debugger_test.c

index 43d28a982d01c1f5a2708f9ed10a60c4a7a3d51a..51f3101a404bb276091a479e9a8b39b4e8ca328b 100644

--- a/tests/debug_stub/debugger_test.c

+++ b/tests/debug_stub/debugger_test.c

@@ -35,7 +35,7 @@ __asm__(".pushsection .text, \"ax\", @progbits\n"

#elif defined(__arm__)

__asm__(".pushsection .text, \"ax\", %progbits\n"

"fault_addr:\n"

- ".word " NACL_TO_STRING(NACL_INSTR_BREAKPOINT) "\n"

+ ".word " NACL_TO_STRING(NACL_INSTR_ARM_BREAKPOINT) "\n"

".popsection\n");

#else

# error Update fault_addr for other architectures

@@ -189,7 +189,7 @@ void breakpoint(void) {

* because BKPTs guard data literals in the ARM sandbox.

__asm__(".p2align 4\n"

- ".word " NACL_TO_STRING(NACL_INSTR_BREAKPOINT) "\n"

+ ".word " NACL_TO_STRING(NACL_INSTR_ARM_BREAKPOINT) "\n"

".p2align 4\n");

#else

# error Unsupported architecture

« no previous file with comments | « src/trusted/validator_arm/model.h ('k') | tests/dynamic_code_loading/dynamic_load_test.c » ('j') | no next file with comments »