sdk/lib/html/src/FilteredElementList.dart - Issue 11269004: Change List.sort to not have a default parameter value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/src/FilteredElementList.dart

Issue 11269004: Change List.sort to not have a default parameter value. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated to tup of tree. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/lib/js_array.dart ('K') | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/html/templates/html/impl/impl_Element.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/html/src/FilteredElementList.dart

diff --git a/sdk/lib/html/src/FilteredElementList.dart b/sdk/lib/html/src/FilteredElementList.dart

index f199b1654ae4cc0f80591e04d5b8bf1add9ff802..5dc7d596bced33c059e84129ea663ec340a55411 100644

--- a/sdk/lib/html/src/FilteredElementList.dart

+++ b/sdk/lib/html/src/FilteredElementList.dart

@@ -52,7 +52,7 @@ class FilteredElementList implements List {

return element is Element && _childNodes.contains(element);

}

- void sort([Comparator<Element> compare = Comparable.compare]) {

+ void sort([int compare(Element a, Element b)]) {

throw new UnsupportedError('TODO(jacobr): should we impl?');

}