Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 11269004: Change List.sort to not have a default parameter value. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated to tup of tree. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index a126afb325dedd23f5d4313b6ee07ec5a4b0ab31..1e9d45f1a9333c61553c71ab1d6dd684f8773604 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -6668,7 +6668,7 @@ class DOMMimeTypeArray extends NativeFieldWrapperClass1 implements List<DOMMimeT
// From List<DOMMimeType>:
- void sort([Comparator<DOMMimeType> compare = Comparable.compare]) {
+ void sort([int compare(DOMMimeType a, DOMMimeType b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -6839,7 +6839,7 @@ class DOMPluginArray extends NativeFieldWrapperClass1 implements List<DOMPlugin>
// From List<DOMPlugin>:
- void sort([Comparator<DOMPlugin> compare = Comparable.compare]) {
+ void sort([int compare(DOMPlugin a, DOMPlugin b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -8436,7 +8436,7 @@ class _ChildrenElementList implements List {
}
}
- void sort([Comparator<Element> compare = Comparable.compare]) {
+ void sort([int compare(Element a, Element b)]) {
throw new UnsupportedError('TODO(jacobr): should we impl?');
}
@@ -8572,7 +8572,7 @@ class _FrozenElementList implements List {
throw new UnsupportedError('');
}
- void sort([Comparator<Element> compare = Comparable.compare]) {
+ void sort([int compare(Element a, Element b)]) {
throw new UnsupportedError('');
}
@@ -10138,7 +10138,7 @@ class FileList extends NativeFieldWrapperClass1 implements List<File> {
// From List<File>:
- void sort([Comparator<File> compare = Comparable.compare]) {
+ void sort([int compare(File a, File b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -10531,7 +10531,7 @@ class Float32Array extends ArrayBufferView implements List<num> {
// From List<num>:
- void sort([Comparator<num> compare = Comparable.compare]) {
+ void sort([int compare(num a, num b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -10672,7 +10672,7 @@ class Float64Array extends ArrayBufferView implements List<num> {
// From List<num>:
- void sort([Comparator<num> compare = Comparable.compare]) {
+ void sort([int compare(num a, num b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -11241,7 +11241,7 @@ class HTMLAllCollection extends NativeFieldWrapperClass1 implements List<Node> {
// From List<Node>:
- void sort([Comparator<Node> compare = Comparable.compare]) {
+ void sort([int compare(Node a, Node b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -11362,7 +11362,7 @@ class HTMLCollection extends NativeFieldWrapperClass1 implements List<Node> {
// From List<Node>:
- void sort([Comparator<Node> compare = Comparable.compare]) {
+ void sort([int compare(Node a, Node b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -12727,7 +12727,7 @@ class Int16Array extends ArrayBufferView implements List<int> {
// From List<int>:
- void sort([Comparator<int> compare = Comparable.compare]) {
+ void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -12868,7 +12868,7 @@ class Int32Array extends ArrayBufferView implements List<int> {
// From List<int>:
- void sort([Comparator<int> compare = Comparable.compare]) {
+ void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -13009,7 +13009,7 @@ class Int8Array extends ArrayBufferView implements List<int> {
// From List<int>:
- void sort([Comparator<int> compare = Comparable.compare]) {
+ void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -15866,7 +15866,7 @@ class NamedNodeMap extends NativeFieldWrapperClass1 implements List<Node> {
// From List<Node>:
- void sort([Comparator<Node> compare = Comparable.compare]) {
+ void sort([int compare(Node a, Node b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -16135,7 +16135,7 @@ class _ChildNodeListLazy implements List {
// TODO(jacobr): this could be implemented for child node lists.
// The exception we throw here is misleading.
- void sort([Comparator<Node> compare = Comparable.compare]) {
+ void sort([int compare(Node a, Node b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -16507,7 +16507,7 @@ class NodeList extends NativeFieldWrapperClass1 implements List<Node> {
// From List<Node>:
- void sort([Comparator<Node> compare = Comparable.compare]) {
+ void sort([int compare(Node a, Node b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -18631,7 +18631,7 @@ class SQLResultSetRowList extends NativeFieldWrapperClass1 implements List<Map>
// From List<Map>:
- void sort([Comparator<Map> compare = Comparable.compare]) {
+ void sort([int compare(Map a, Map b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -19330,7 +19330,7 @@ class SourceBufferList extends EventTarget implements List<SourceBuffer> {
// From List<SourceBuffer>:
- void sort([Comparator<SourceBuffer> compare = Comparable.compare]) {
+ void sort([int compare(SourceBuffer a, SourceBuffer b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -19539,7 +19539,7 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 implements List<SpeechG
// From List<SpeechGrammar>:
- void sort([Comparator<SpeechGrammar> compare = Comparable.compare]) {
+ void sort([int compare(SpeechGrammar a, SpeechGrammar b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -21206,7 +21206,7 @@ class TextTrackCueList extends NativeFieldWrapperClass1 implements List<TextTrac
// From List<TextTrackCue>:
- void sort([Comparator<TextTrackCue> compare = Comparable.compare]) {
+ void sort([int compare(TextTrackCue a, TextTrackCue b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -21327,7 +21327,7 @@ class TextTrackList extends EventTarget implements List<TextTrack> {
// From List<TextTrack>:
- void sort([Comparator<TextTrack> compare = Comparable.compare]) {
+ void sort([int compare(TextTrack a, TextTrack b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -21608,7 +21608,7 @@ class TouchList extends NativeFieldWrapperClass1 implements List<Touch> {
// From List<Touch>:
- void sort([Comparator<Touch> compare = Comparable.compare]) {
+ void sort([int compare(Touch a, Touch b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -21998,7 +21998,7 @@ class Uint16Array extends ArrayBufferView implements List<int> {
// From List<int>:
- void sort([Comparator<int> compare = Comparable.compare]) {
+ void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -22139,7 +22139,7 @@ class Uint32Array extends ArrayBufferView implements List<int> {
// From List<int>:
- void sort([Comparator<int> compare = Comparable.compare]) {
+ void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -22280,7 +22280,7 @@ class Uint8Array extends ArrayBufferView implements List<int> {
// From List<int>:
- void sort([Comparator<int> compare = Comparable.compare]) {
+ void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -24934,7 +24934,7 @@ class _CSSRuleList extends NativeFieldWrapperClass1 implements List<CSSRule> {
// From List<CSSRule>:
- void sort([Comparator<CSSRule> compare = Comparable.compare]) {
+ void sort([int compare(CSSRule a, CSSRule b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -25047,7 +25047,7 @@ class _CSSValueList extends CSSValue implements List<CSSValue> {
// From List<CSSValue>:
- void sort([Comparator<CSSValue> compare = Comparable.compare]) {
+ void sort([int compare(CSSValue a, CSSValue b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -25160,7 +25160,7 @@ class _ClientRectList extends NativeFieldWrapperClass1 implements List<ClientRec
// From List<ClientRect>:
- void sort([Comparator<ClientRect> compare = Comparable.compare]) {
+ void sort([int compare(ClientRect a, ClientRect b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -25281,7 +25281,7 @@ class _DOMStringList extends NativeFieldWrapperClass1 implements List<String> {
// From List<String>:
- void sort([Comparator<String> compare = Comparable.compare]) {
+ void sort([int compare(String a, String b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -25542,7 +25542,7 @@ class _EntryArray extends NativeFieldWrapperClass1 implements List<Entry> {
// From List<Entry>:
- void sort([Comparator<Entry> compare = Comparable.compare]) {
+ void sort([int compare(Entry a, Entry b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -25655,7 +25655,7 @@ class _EntryArraySync extends NativeFieldWrapperClass1 implements List<EntrySync
// From List<EntrySync>:
- void sort([Comparator<EntrySync> compare = Comparable.compare]) {
+ void sort([int compare(EntrySync a, EntrySync b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -25800,7 +25800,7 @@ class _GamepadList extends NativeFieldWrapperClass1 implements List<Gamepad> {
// From List<Gamepad>:
- void sort([Comparator<Gamepad> compare = Comparable.compare]) {
+ void sort([int compare(Gamepad a, Gamepad b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -25962,7 +25962,7 @@ class _MediaStreamList extends NativeFieldWrapperClass1 implements List<MediaStr
// From List<MediaStream>:
- void sort([Comparator<MediaStream> compare = Comparable.compare]) {
+ void sort([int compare(MediaStream a, MediaStream b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -26179,7 +26179,7 @@ class _SpeechInputResultList extends NativeFieldWrapperClass1 implements List<Sp
// From List<SpeechInputResult>:
- void sort([Comparator<SpeechInputResult> compare = Comparable.compare]) {
+ void sort([int compare(SpeechInputResult a, SpeechInputResult b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -26300,7 +26300,7 @@ class _SpeechRecognitionResultList extends NativeFieldWrapperClass1 implements L
// From List<SpeechRecognitionResult>:
- void sort([Comparator<SpeechRecognitionResult> compare = Comparable.compare]) {
+ void sort([int compare(SpeechRecognitionResult a, SpeechRecognitionResult b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -26413,7 +26413,7 @@ class _StyleSheetList extends NativeFieldWrapperClass1 implements List<StyleShee
// From List<StyleSheet>:
- void sort([Comparator<StyleSheet> compare = Comparable.compare]) {
+ void sort([int compare(StyleSheet a, StyleSheet b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -26534,7 +26534,7 @@ class _WebKitAnimationList extends NativeFieldWrapperClass1 implements List<Anim
// From List<Animation>:
- void sort([Comparator<Animation> compare = Comparable.compare]) {
+ void sort([int compare(Animation a, Animation b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -27150,7 +27150,7 @@ class FilteredElementList implements List {
return element is Element && _childNodes.contains(element);
}
- void sort([Comparator<Element> compare = Comparable.compare]) {
+ void sort([int compare(Element a, Element b)]) {
throw new UnsupportedError('TODO(jacobr): should we impl?');
}

Powered by Google App Engine
This is Rietveld 408576698