Change all one-off lifecycle callers to FrameView::updateLayoutAndStyleForPainting

Change all one-off lifecycle callers to FrameView::updateLayoutAndStyleForPainting

This makes sure that the compositing and paint invalidation steps are not missed.
Compositing in particular is needed for hit testing.

Second, fix FrameView::updateLayoutAndStyleForPainting to always start from the
root document frame. Otherwise parent frames of the current frame may not get
advanced, and we may end up with inconsistent lifecycle states across these frames,
which can lead to all kinds of havoc.

Finally, make several related methods private in FrameView to help enforce correct
behavior.

BUG=476590
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195138

[chrishtr, 2015-05-05 22:47:42]

chrishtr@chromium.org changed reviewers:
+ leviw@chromium.org

[chrishtr, 2015-05-05 22:47:43]

I encountered this while investigating the attached bug. Without advancing to
compositing clean, virtual/slimmingpaint/fast/multicol/hit-test-translate-z.html
would have asserted, due to use of Document::elementFromPoint, which in turn
calls hit testing, and does not advance far enough.

[leviw_travelin_and_unemployed, 2015-05-05 23:12:57]

On 2015/05/05 at 22:47:43, chrishtr wrote:
> I encountered this while investigating the attached bug. Without advancing to
compositing clean, virtual/slimmingpaint/fast/multicol/hit-test-translate-z.html
would have asserted, due to use of Document::elementFromPoint, which in turn
calls hit testing, and does not advance far enough.

This is asserting on mac_blink_rel.

[chrishtr, 2015-05-08 00:33:36]

chrishtr@chromium.org changed reviewers:
+ esprehn@chromium.org

[chrishtr, 2015-05-08 00:33:37]

https://codereview.chromium.org/1126883002/diff/40001/Source/core/page/EventH...
File Source/core/page/EventHandler.cpp (left):

https://codereview.chromium.org/1126883002/diff/40001/Source/core/page/EventH...
Source/core/page/EventHandler.cpp:2426: LocalFrame* mainFrame =
m_frame->localFrameRoot();
These are not needed because of the code in LayoutView::hitTest().

[esprehn, 2015-05-08 20:44:17]

Seems reasonable, eventually I think we want to walk up the ancestor chain
instead to avoid doing work on sibling frames that isn't needed, but lets start
here.

lgtm

[chrishtr, 2015-05-08 20:45:08]

Uploaded a new patch. Turns out we did need the code in EventHandler, so that
adjustedPoint is set correctly.

[chrishtr, 2015-05-08 20:56:25]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-05-08 20:57:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126883002/100001

[commit-bot: I haz the power, 2015-05-09 05:21:01]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195138