Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7089)

Unified Diff: chrome/installer/util/chrome_app_host_distribution.cc

Issue 11267023: Implementing --app-launcher install/uninstall flow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/chrome_app_host_distribution.cc
diff --git a/chrome/installer/util/chrome_app_host_distribution.cc b/chrome/installer/util/chrome_app_host_distribution.cc
index da20de6eea52160ba90b34098ae5ed3d09c03557..abc6af1bfcb235b4203bc1fb244c7c8b89dae166 100644
--- a/chrome/installer/util/chrome_app_host_distribution.cc
+++ b/chrome/installer/util/chrome_app_host_distribution.cc
@@ -60,14 +60,10 @@ string16 ChromeAppHostDistribution::GetPublisherName() {
}
string16 ChromeAppHostDistribution::GetAppDescription() {
- NOTREACHED() << "This should never be accessed due to no start-menu/task-bar "
- << "shortcuts.";
return L"A standalone platform for Chrome apps.";
erikwright (departed) 2012/10/25 02:23:03 Needs to become a localizable resource. (Also bel
grt (UTC plus 2) 2012/10/25 14:46:53 Is this ever built for branding=Chromium?
huangs 2012/10/29 21:15:16 This has not been built for Chromium.
huangs 2012/10/29 21:15:16 Will make this localizable once we create shortcut
grt (UTC plus 2) 2012/10/30 13:02:55 Is it possible to put in a safeguard so that it ne
erikwright (departed) 2012/10/30 14:20:39 We don't do anything to prevent it, but there are
erikwright (departed) 2012/10/30 14:20:39 I spoke with grt, as long as the strings are inter
}
string16 ChromeAppHostDistribution::GetLongAppDescription() {
- NOTREACHED() << "This should never be accessed as Chrome App Host is not a "
- << "default browser option.";
return L"A standalone platform for Chrome apps.";
}
@@ -102,14 +98,10 @@ std::string ChromeAppHostDistribution::GetHttpPipeliningTestServer() const {
}
string16 ChromeAppHostDistribution::GetUninstallLinkName() {
- NOTREACHED() << "This should never be accessed as Chrome App Host has no "
- << "uninstall entry.";
return L"Uninstall Chrome App Host";
}
string16 ChromeAppHostDistribution::GetUninstallRegPath() {
- NOTREACHED() << "This should never be accessed as Chrome App Host has no "
- << "uninstall entry.";
return L"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\"
L"Google Chrome App Host";
}
@@ -126,7 +118,7 @@ bool ChromeAppHostDistribution::CanSetAsDefault() {
}
bool ChromeAppHostDistribution::CanCreateDesktopShortcuts() {
- return false;
+ return true;
}
bool ChromeAppHostDistribution::GetCommandExecuteImplClsid(

Powered by Google App Engine
This is Rietveld 408576698