Implementing --app-launcher install/uninstall flow.

chrome/installer/util/chrome_app_host_distribution.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines a specific implementation of BrowserDistribution class for
 // Chrome App Host. It overrides the bare minimum of methods necessary to get a
 // Chrome App Host installer that does not interact with Google Chrome or
 // Chromium installations.
 
 #include "chrome/installer/util/chrome_app_host_distribution.h"
@@ skipping 42 matching lines @@
       BrowserDistribution::CHROME_BINARIES)->GetInstallSubDir();
 }
 
 string16 ChromeAppHostDistribution::GetPublisherName() {
   const string16& publisher_name =
       installer::GetLocalizedString(IDS_ABOUT_VERSION_COMPANY_NAME_BASE);
   return publisher_name;
 }
 
 string16 ChromeAppHostDistribution::GetAppDescription() {
-  NOTREACHED() << "This should never be accessed due to no start-menu/task-bar "
-               << "shortcuts.";
   return L"A standalone platform for Chrome apps.";

[erikwright (departed), 2012/10/25 02:23:03]

Needs to become a localizable resource.

(Also below);

[grt (UTC plus 2), 2012/10/25 14:46:53]

Is this ever built for branding=Chromium?

[huangs, 2012/10/29 21:15:16]

This has not been built for Chromium.

[huangs, 2012/10/29 21:15:16]

Will make this localizable once we create shortcuts.  Moot for this CL.

[grt (UTC plus 2), 2012/10/30 13:02:55]

Is it possible to put in a safeguard so that it never will be built for
Chromium?

[erikwright (departed), 2012/10/30 14:20:39]

We don't do anything to prevent it, but there are a lot of steps between where
we are today and making this useful in Chromium.

[erikwright (departed), 2012/10/30 14:20:39]

I spoke with grt, as long as the strings are internationalized (i.e., defined
separately and appropriately for Chrome and Chromium builds), it's not an issue.

If these strings are only required for the shortcuts CL, please remove them from
this one.

If they are required for the Add/Remove registration, please do the
internationalization.

 }
 
 string16 ChromeAppHostDistribution::GetLongAppDescription() {
-  NOTREACHED() << "This should never be accessed as Chrome App Host is not a "
-               << "default browser option.";
   return L"A standalone platform for Chrome apps.";
 }
 
 std::string ChromeAppHostDistribution::GetSafeBrowsingName() {
   return "googlechromeapphost";
 }
 
 string16 ChromeAppHostDistribution::GetStateKey() {
   string16 key(google_update::kRegPathClientState);
   key.append(L"\\");
@@ skipping 14 matching lines @@
 
 std::string ChromeAppHostDistribution::GetNetworkStatsServer() const {
   return chrome_common_net::kEchoTestServerLocation;
 }
 
 std::string ChromeAppHostDistribution::GetHttpPipeliningTestServer() const {
   return chrome_common_net::kPipelineTestServerBaseUrl;
 }
 
 string16 ChromeAppHostDistribution::GetUninstallLinkName() {
-  NOTREACHED() << "This should never be accessed as Chrome App Host has no "
-               << "uninstall entry.";
   return L"Uninstall Chrome App Host";
 }
 
 string16 ChromeAppHostDistribution::GetUninstallRegPath() {
-  NOTREACHED() << "This should never be accessed as Chrome App Host has no "
-               << "uninstall entry.";
   return L"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\"
          L"Google Chrome App Host";
 }
 
 string16 ChromeAppHostDistribution::GetVersionKey() {
   string16 key(google_update::kRegPathClients);
   key.append(L"\\");
   key.append(kChromeAppHostGuid);
   return key;
 }
 
 bool ChromeAppHostDistribution::CanSetAsDefault() {
   return false;
 }
 
 bool ChromeAppHostDistribution::CanCreateDesktopShortcuts() {
-  return false;
+  return true;
 }
 
 bool ChromeAppHostDistribution::GetCommandExecuteImplClsid(
     string16* handler_class_uuid) {
   return false;
 }
 
 void ChromeAppHostDistribution::UpdateInstallStatus(bool system_install,
     installer::ArchiveType archive_type,
     installer::InstallStatus install_status) {
 #if defined(GOOGLE_CHROME_BUILD)
   GoogleUpdateSettings::UpdateInstallStatus(system_install,
       archive_type, InstallUtil::GetInstallReturnCode(install_status),
       kChromeAppHostGuid);
 #endif
 }