Chromium Code Reviews
Help | Chromium Project | Sign in
(217)

Issue 11267003: Add chromeos_unittests to the main waterfall. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Peter Mayo
Modified:
1 year, 4 months ago
CC:
chromium-reviews_chromium.org, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Add chromeos_unittests to the main waterfall.

BUG=147658
TEST=local waterfalls

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169314

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -88 lines) Lint Patch
M masters/master.chromium.chromiumos/master_chromiumos_cfg.py View 1 2 3 4 10 chunks +51 lines, -88 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 10
Peter Mayo
1 year, 5 months ago #1
Peter Mayo
Wrong Mike.
1 year, 5 months ago #2
Peter Mayo
1 year, 5 months ago #3
Peter Mayo
On 2012/10/27 04:09:36, Peter Mayo wrote: Should look familiar.
1 year, 5 months ago #4
M-A Ruel
http://codereview.chromium.org/11267003/diff/5001/masters/master.chromium.chromiumos/master_chromiumos_cfg.py File masters/master.chromium.chromiumos/master_chromiumos_cfg.py (right): http://codereview.chromium.org/11267003/diff/5001/masters/master.chromium.chromiumos/master_chromiumos_cfg.py#newcode39 masters/master.chromium.chromiumos/master_chromiumos_cfg.py:39: linux_chromeos_tests = [ I think you should create 3 ...
1 year, 5 months ago #5
Peter Mayo
On 2012/10/28 00:20:55, Marc-Antoine Ruel wrote: > http://codereview.chromium.org/11267003/diff/5001/masters/master.chromium.chromiumos/master_chromiumos_cfg.py > File masters/master.chromium.chromiumos/master_chromiumos_cfg.py (right): > > http://codereview.chromium.org/11267003/diff/5001/masters/master.chromium.chromiumos/master_chromiumos_cfg.py#newcode39 ...
1 year, 5 months ago #6
M-A Ruel
On 2012/11/05 01:29:59, Peter Mayo wrote: > On 2012/10/28 00:20:55, Marc-Antoine Ruel wrote: > > ...
1 year, 5 months ago #7
Mike Stip (use stip instead)
lgtm
1 year, 5 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/11267003/9002
1 year, 4 months ago #9
I haz the power (commit-bot)
1 year, 4 months ago #10
Message was sent while issue was closed.
Change committed as 169314
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6