Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 1126643003: Merge to XFA: Fix issuse with != and == shown by fx_basic_bstring unit tests. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix issuse with != and == shown by fx_basic_bstring unit tests. Original Review URL: https://codereview.chromium.org/1125703004 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/72d07de1933bae3569be19a31be3f75aa7265930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -60 lines) Patch
M core/include/fxcrt/fx_string.h View 4 chunks +41 lines, -33 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 chunk +21 lines, -8 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 6 chunks +3 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd.
5 years, 7 months ago (2015-05-04 21:13:06 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 72d07de1933bae3569be19a31be3f75aa7265930 (presubmit successful).
5 years, 7 months ago (2015-05-04 21:14:36 UTC) #2
Lei Zhang
5 years, 7 months ago (2015-05-04 21:43:58 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698