Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1125703004: Fix issuse with != and == shown by fx_basic_bstring unit tests. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix issuse with != and == shown by fx_basic_bstring unit tests. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/447e2beb38d5bd8b71b1ddc3df448559dbd588af

Patch Set 1 #

Patch Set 2 : More code in .cpp to avoid possible bloat. #

Patch Set 3 : Tidy, avoid typedefs to improve transparency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -60 lines) Patch
M core/include/fxcrt/fx_string.h View 1 2 4 chunks +41 lines, -33 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 2 1 chunk +21 lines, -8 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 6 chunks +3 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review. Thanks.
5 years, 7 months ago (2015-05-04 16:32:44 UTC) #2
Lei Zhang
lgtm typo in commit msg
5 years, 7 months ago (2015-05-04 20:53:44 UTC) #3
Tom Sepez
5 years, 7 months ago (2015-05-04 21:03:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
447e2beb38d5bd8b71b1ddc3df448559dbd588af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698