Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java

Issue 1126543009: [Android] Refactor the native test wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java
diff --git a/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java b/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java
index bbf2461f158b360f734173c282031b369ebac98f..17e0bc4d84f1d8e27564fdab3d1731a6e9600ea3 100644
--- a/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java
+++ b/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java
@@ -4,38 +4,32 @@
package org.chromium.components_browsertests_apk;
-import android.app.Activity;
-import android.content.Context;
-import android.os.Bundle;
-import android.os.Handler;
-import android.util.Log;
import android.view.Window;
import android.view.WindowManager;
-import org.chromium.base.JNINamespace;
+import org.chromium.base.Log;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.library_loader.LibraryLoader;
import org.chromium.base.library_loader.LibraryProcessType;
import org.chromium.base.library_loader.ProcessInitException;
import org.chromium.content.browser.BrowserStartupController;
import org.chromium.content_shell.ShellManager;
+import org.chromium.native_test.NativeBrowserTestActivity;
import org.chromium.ui.base.ActivityWindowAndroid;
import org.chromium.ui.base.WindowAndroid;
/**
* Android activity for running components browser tests
*/
-@JNINamespace("components")
-public class ComponentsBrowserTestsActivity extends Activity {
- private static final String TAG = "ComponentsBrowserTestsActivity";
+public class ComponentsBrowserTestsActivity extends NativeBrowserTestActivity {
+ private static final String TAG = Log.makeTag("native_test");
private ShellManager mShellManager;
private WindowAndroid mWindowAndroid;
@Override
@SuppressFBWarnings("DM_EXIT")
- public void onCreate(Bundle savedInstanceState) {
- super.onCreate(savedInstanceState);
+ protected void startBrowser() {
try {
LibraryLoader.get(LibraryProcessType.PROCESS_BROWSER).ensureInitialized();
@@ -55,21 +49,5 @@ public class ComponentsBrowserTestsActivity extends Activity {
wind.addFlags(WindowManager.LayoutParams.FLAG_DISMISS_KEYGUARD);
wind.addFlags(WindowManager.LayoutParams.FLAG_SHOW_WHEN_LOCKED);
wind.addFlags(WindowManager.LayoutParams.FLAG_TURN_SCREEN_ON);
-
- new Handler().post(new Runnable() {
- @Override
- public void run() {
- Log.i(TAG, "Running tests");
- runTests();
- Log.i(TAG, "Tests finished.");
- finish();
- }
- });
- }
-
- private void runTests() {
- nativeRunTests(getFilesDir().getAbsolutePath(), getApplicationContext());
}
-
- private native void nativeRunTests(String filesDir, Context appContext);
}

Powered by Google App Engine
This is Rietveld 408576698