Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: testing/android/native_test/java/src/org/chromium/native_test/NativeBrowserTestActivity.java

Issue 1126543009: [Android] Refactor the native test wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/android/native_test/java/src/org/chromium/native_test/NativeBrowserTestActivity.java
diff --git a/testing/android/native_test/java/src/org/chromium/native_test/NativeBrowserTestActivity.java b/testing/android/native_test/java/src/org/chromium/native_test/NativeBrowserTestActivity.java
new file mode 100644
index 0000000000000000000000000000000000000000..8083cc009a328ed0d7981d0826f44660f5c34496
--- /dev/null
+++ b/testing/android/native_test/java/src/org/chromium/native_test/NativeBrowserTestActivity.java
@@ -0,0 +1,23 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.native_test;
+
+import android.os.Bundle;
+
+/**
+ * An {@link android.app.Activity} for running native browser tests.
+ */
+public abstract class NativeBrowserTestActivity extends NativeTestActivity {
+
+ @Override
+ public void onCreate(Bundle savedInstanceState) {
+ super.onCreate(savedInstanceState);
+ startBrowser();
+ loadLibraries();
Ted C 2015/05/05 23:11:17 what libraries is it loading here? this looks bac
jbudorick 2015/05/06 18:00:00 For both browser tests and unit tests, it just app
+ }
+
+ protected abstract void startBrowser();
Ted C 2015/05/05 23:11:17 Add some javadoc here. Also, does the browser nee
jbudorick 2015/05/06 18:00:00 No. After looking at this more, startBrowser is a
+
+}

Powered by Google App Engine
This is Rietveld 408576698