Source/core/page/DragController.cpp - Issue 112653006: Make calls to AtomicString(const String&) explicit in page/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DragController.cpp

Issue 112653006: Make calls to AtomicString(const String&) explicit in page/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/DragController.cpp

diff --git a/Source/core/page/DragController.cpp b/Source/core/page/DragController.cpp

index 8a56f75d594ef36f29ce509c49306c31157c5ca4..2eb8351eaf68e30e7f6fb232a0a135c4f383c9fc 100644

--- a/Source/core/page/DragController.cpp

+++ b/Source/core/page/DragController.cpp

@@ -166,7 +166,7 @@ static PassRefPtr<DocumentFragment> documentFragmentFromDragData(DragData* dragD

String url = dragData->asURL(DragData::DoNotConvertFilenames, &title);

if (!url.isEmpty()) {

RefPtr<HTMLAnchorElement> anchor = HTMLAnchorElement::create(document);

- anchor->setHref(url);

+ anchor->setHref(AtomicString(url));

if (title.isEmpty()) {

// Try the plain text first because the url might be normalized or escaped.

if (dragData->containsPlainText())

« no previous file with comments | « Source/core/page/CreateWindow.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »