Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: Source/core/page/CreateWindow.cpp

Issue 112653006: Make calls to AtomicString(const String&) explicit in page/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/page/DragController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/CreateWindow.cpp
diff --git a/Source/core/page/CreateWindow.cpp b/Source/core/page/CreateWindow.cpp
index 2ba2123c7d6d74504822d705275be27d0da45e50..16155c00ef8f35a480835494c4de2e70a32cdc01 100644
--- a/Source/core/page/CreateWindow.cpp
+++ b/Source/core/page/CreateWindow.cpp
@@ -130,8 +130,8 @@ Frame* createWindow(const String& urlString, const AtomicString& frameName, cons
// For whatever reason, Firefox uses the first frame to determine the outgoingReferrer. We replicate that behavior here.
String referrer = SecurityPolicy::generateReferrerHeader(firstFrame->document()->referrerPolicy(), completedURL, firstFrame->document()->outgoingReferrer());
- ResourceRequest request(completedURL, referrer);
- FrameLoader::addHTTPOriginIfNeeded(request, firstFrame->document()->outgoingOrigin());
+ ResourceRequest request(completedURL, AtomicString(referrer));
+ FrameLoader::addHTTPOriginIfNeeded(request, AtomicString(firstFrame->document()->outgoingOrigin()));
FrameLoadRequest frameRequest(activeWindow->document(), request, frameName);
// We pass the opener frame for the lookupFrame in case the active frame is different from
@@ -151,7 +151,7 @@ Frame* createWindow(const String& urlString, const AtomicString& frameName, cons
function(newFrame->domWindow(), functionContext);
if (created) {
- FrameLoadRequest request(activeWindow->document(), ResourceRequest(completedURL, referrer));
+ FrameLoadRequest request(activeWindow->document(), ResourceRequest(completedURL, AtomicString(referrer)));
newFrame->loader().load(request);
} else if (!urlString.isEmpty()) {
newFrame->navigationScheduler().scheduleLocationChange(activeWindow->document(), completedURL.string(), referrer, false);
« no previous file with comments | « no previous file | Source/core/page/DragController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698