Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: tools/telemetry/telemetry/benchmark.py

Issue 1126443002: Move user_story.user_story_set to story.story_set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/session_restore.py ('k') | tools/telemetry/telemetry/benchmark_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/benchmark.py
diff --git a/tools/telemetry/telemetry/benchmark.py b/tools/telemetry/telemetry/benchmark.py
index 48e244d125e533c7abab87ec3fbfefb8c7e04262..b3799434ab8d6286fa5c34478a95613046534c5d 100644
--- a/tools/telemetry/telemetry/benchmark.py
+++ b/tools/telemetry/telemetry/benchmark.py
@@ -58,7 +58,7 @@ class Benchmark(command_line.Command):
Benchmarks default to using TBM unless you override the value of
Benchmark.test, or override the CreatePageTest method.
- New benchmarks should override CreateUserStorySet.
+ New benchmarks should override CreateStorySet.
"""
options = {}
test = timeline_based_measurement.TimelineBasedMeasurement
@@ -184,11 +184,11 @@ class Benchmark(command_line.Command):
pt._enabled_strings = self._enabled_strings
expectations = self.CreateExpectations()
- us = self.CreateUserStorySet(finder_options)
+ us = self.CreateStorySet(finder_options)
if isinstance(pt, page_test.PageTest):
if any(not isinstance(p, page.Page) for p in us.user_stories):
raise Exception(
- 'PageTest must be used with UserStorySet containing only '
+ 'PageTest must be used with StorySet containing only '
'telemetry.page.Page user stories.')
self._DownloadGeneratedProfileArchive(finder_options)
@@ -327,7 +327,7 @@ class Benchmark(command_line.Command):
raise TypeError('"%s" is not a PageSet.' % self.page_set.__name__)
return self.page_set()
- def CreateUserStorySet(self, options):
+ def CreateStorySet(self, options):
return self.CreatePageSet(options)
@classmethod
« no previous file with comments | « tools/perf/benchmarks/session_restore.py ('k') | tools/telemetry/telemetry/benchmark_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698